Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20296)

Issue 43420043: code review 43420043: ld: fix Plan 9 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by 0intro
Modified:
10 years, 4 months ago
Reviewers:
jas, bradfitz
CC:
golang-dev, jas, bradfitz
Visibility:
Public.

Description

ld: fix Plan 9 build

Patch Set 1 #

Patch Set 2 : diff -r fe20c205df9f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/ld/pobj.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
0intro
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2013-12-17 13:27:38 UTC) #1
jas
lgtm you also used a more apt title than I just tried, build: NULL is ...
10 years, 4 months ago (2013-12-17 15:48:04 UTC) #2
bradfitz
LGTM On Tue, Dec 17, 2013 at 5:27 PM, <0intro@gmail.com> wrote: > Reviewers: golang-dev1, > ...
10 years, 4 months ago (2013-12-17 16:45:59 UTC) #3
bradfitz
10 years, 4 months ago (2013-12-17 16:46:10 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=8cb5c6892fbc ***

ld: fix Plan 9 build

R=golang-dev, jas, bradfitz
CC=golang-dev
https://codereview.appspot.com/43420043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b