code review 42930045: jwt: add JWT authenticated transport and client.

jwt: add JWT authenticated transport and client.

Self-refreshing OAuth transport and client needed by the
google-api-go-client services (i.e. to provide it out of
the box the same way as oauth.Transport, but for service
accounts).

[karalabe, 2013-12-16 23:49:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/goauth2

[gobot, 2013-12-19 21:25:45]

R=adg@golang.org (assigned by r@golang.org)

[gobot, 2013-12-20 16:26:10]

Replacing golang-dev with golang-codereviews.

[adg, 2014-01-29 06:50:26]

This looks great.

https://codereview.appspot.com/42930045/diff/60001/oauth/jwt/jwt.go
File oauth/jwt/jwt.go (right):

https://codereview.appspot.com/42930045/diff/60001/oauth/jwt/jwt.go#newcode431
oauth/jwt/jwt.go:431: JwtToken   *Token
This should be JWTToken or Token.
I don't like the incorrectly-capitalized "Jwt".

[karalabe, 2014-01-29 09:15:50]

On 2014/01/29 06:50:26, adg wrote:
> This looks great.
> 
> https://codereview.appspot.com/42930045/diff/60001/oauth/jwt/jwt.go
> File oauth/jwt/jwt.go (right):
> 
> https://codereview.appspot.com/42930045/diff/60001/oauth/jwt/jwt.go#newcode431
> oauth/jwt/jwt.go:431: JwtToken   *Token
> This should be JWTToken or Token.
> I don't like the incorrectly-capitalized "Jwt".

I'll update is ASAP after the FOSDEM devroom (until then I'm depending on it
this way and don't want to break anything :D).

Nonetheless, tests are still warranted before going forward with this as there
*may* be (i.e. probably) a bug in the automatic refresh of the keys. I'm using
it for both the Google Cloud Storage and the Datastore, but the latter keeps
returning an error after key refresh and I hadn't had time to figure out the
reason.

[adg, 2014-01-29 12:12:17]

Let's talk about it at FOSDEM :)


On 29 January 2014 20:15, <peterke@gmail.com> wrote:

> On 2014/01/29 06:50:26, adg wrote:
>
>> This looks great.
>>
>
>  https://codereview.appspot.com/42930045/diff/60001/oauth/jwt/jwt.go
>> File oauth/jwt/jwt.go (right):
>>
>
>
> https://codereview.appspot.com/42930045/diff/60001/oauth/
> jwt/jwt.go#newcode431
>
>> oauth/jwt/jwt.go:431: JwtToken   *Token
>> This should be JWTToken or Token.
>> I don't like the incorrectly-capitalized "Jwt".
>>
>
> I'll update is ASAP after the FOSDEM devroom (until then I'm depending
> on it this way and don't want to break anything :D).
>
> Nonetheless, tests are still warranted before going forward with this as
> there *may* be (i.e. probably) a bug in the automatic refresh of the
> keys. I'm using it for both the Google Cloud Storage and the Datastore,
> but the latter keeps returning an error after key refresh and I hadn't
> had time to figure out the reason.
>
> https://codereview.appspot.com/42930045/
>

[karalabe, 2014-02-09 19:18:46]

Hello golang-codereviews@googlegroups.com, gobot@golang.org, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[karalabe, 2014-02-09 19:21:31]

Ah, I thought I get to add an own message two. Sorry for the double mail.

I've found the refresh bug too. The request time in the claimset doesn't get
reset when fetching a new token, hence the new token will already be expired :P.
I'll prep a fix and CL in a few mins.

On 2014/02/09 19:18:46, karalabe wrote:
> Hello mailto:golang-codereviews@googlegroups.com, mailto:gobot@golang.org,
mailto:adg@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[karalabe, 2014-02-09 21:33:18]

And just for the reference, the refresh fix:
https://codereview.appspot.com/61300043/

On 2014/02/09 19:21:31, karalabe wrote:
> Ah, I thought I get to add an own message two. Sorry for the double mail.
> 
> I've found the refresh bug too. The request time in the claimset doesn't get
> reset when fetching a new token, hence the new token will already be expired
:P.
> I'll prep a fix and CL in a few mins.
> 
> On 2014/02/09 19:18:46, karalabe wrote:
> > Hello mailto:golang-codereviews@googlegroups.com, mailto:gobot@golang.org,
> mailto:adg@golang.org (cc:
> > mailto:golang-dev@googlegroups.com),
> > 
> > Please take another look.

[adg, 2014-02-11 06:31:04]

LGTM

[adg, 2014-02-11 06:31:29]

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=fa3262e2e228
***

jwt: add JWT authenticated transport and client.

Self-refreshing OAuth transport and client needed by the
google-api-go-client services (i.e. to provide it out of
the box the same way as oauth.Transport, but for service
accounts).

LGTM=adg
R=golang-codereviews, gobot, adg
CC=golang-dev
https://codereview.appspot.com/42930045

Committer: Andrew Gerrand <adg@golang.org>