Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(310)

Issue 4243041: Change keep-inside-line defaults to true. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Graham Percival (old account)
Modified:
13 years, 1 month ago
Reviewers:
ahawryluk, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Change keep-inside-line defaults to true. As discussed in Issue \#1470, the default should be changed so that good layout with a slight performance hit is the default.

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix bad file edit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -245 lines) Patch
M Documentation/learning/tweaks.itely View 2 chunks +0 lines, -35 lines 0 comments Download
M Documentation/notation/text.itely View 1 chunk +3 lines, -4 lines 0 comments Download
M Documentation/notation/vocal.itely View 1 chunk +4 lines, -4 lines 0 comments Download
M Documentation/snippets/new/ancient-headword.ly View 1 chunk +0 lines, -8 lines 0 comments Download
M Documentation/snippets/new/chords-headword.ly View 1 chunk +0 lines, -8 lines 0 comments Download
M Documentation/snippets/new/editorial-headword.ly View 1 chunk +0 lines, -8 lines 0 comments Download
M Documentation/snippets/new/figured-bass-headword.ly View 1 chunk +0 lines, -8 lines 0 comments Download
M Documentation/snippets/new/fretted-headword.ly View 1 chunk +0 lines, -2 lines 0 comments Download
M Documentation/snippets/new/pitches-headword.ly View 1 chunk +0 lines, -8 lines 0 comments Download
M Documentation/snippets/new/simultaneous-headword.ly View 1 chunk +0 lines, -9 lines 0 comments Download
M Documentation/snippets/new/text-headword.ly View 1 chunk +0 lines, -8 lines 0 comments Download
M Documentation/web/ly-examples/example-header.ily View 1 chunk +0 lines, -8 lines 0 comments Download
M input/regression/balloon.ly View 1 chunk +14 lines, -5 lines 0 comments Download
M input/regression/font-bogus-ligature.ly View 1 chunk +11 lines, -2 lines 0 comments Download
M input/regression/font-family-override.ly View 1 chunk +21 lines, -11 lines 0 comments Download
M input/regression/font-name.ly View 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/hairpin-ending.ly View 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/harp-pedals-sanity-checks.ly View 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/harp-pedals-tweaking.ly View 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/lyric-extender-right-margin.ly View 2 chunks +1 line, -2 lines 0 comments Download
M input/regression/lyrics-no-notes.ly View 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/markup-commands.ly View 1 chunk +32 lines, -23 lines 0 comments Download
M input/regression/markup-note.ly View 1 chunk +55 lines, -45 lines 0 comments Download
M input/regression/markup-syntax.ly View 1 chunk +49 lines, -39 lines 0 comments Download
M input/regression/markup-user.ly View 1 chunk +11 lines, -4 lines 0 comments Download
M input/regression/skyline-vertical-placement.ly View 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/spacing-stick-out.ly View 2 chunks +3 lines, -4 lines 0 comments Download
M scm/define-grobs.scm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
hanwenn
http://codereview.appspot.com/4243041/diff/1/Documentation/snippets/editorial-headword.ly File Documentation/snippets/editorial-headword.ly (right): http://codereview.appspot.com/4243041/diff/1/Documentation/snippets/editorial-headword.ly#newcode2 Documentation/snippets/editorial-headword.ly:2: % generated from Documentation/snippets/new why is this editing a ...
13 years, 1 month ago (2011-02-28 00:16:10 UTC) #1
ahawryluk
My bad! The attached post corrects this oversight. Graham, can you upload this? I won't ...
13 years, 1 month ago (2011-02-28 04:21:06 UTC) #2
Graham Percival (old account)
13 years, 1 month ago (2011-02-28 07:44:34 UTC) #3
New patch uploaded, but I'm not totally certain it's correct.  The message in
Documentation/snippets/* is misleading -- you shouldn't edit them directly
(instead, edit stuff in /new/ ), but of course those files are modified when you
run makelsr.py, and those modifications should be committed to git.

Andrew - don't worry about this.  If nobody finds a significant problem in the
next 24 hours, I'll apply it to my git, run makelsr, and push the result.

I will change makelsr.py right now to avoid this problem in the future.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b