Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 4119053: code review 4119053: syscall: add SetsockoptIpMreq (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by dfc
Modified:
4 years, 7 months ago
Reviewers:
CC:
rsc, mikio, golang-dev
Visibility:
Public.

Description

syscall: add SetsockoptIpMreq notes: * due to Issue 1466 the Msghdr struct for src/pkg/syscall/ztypes_darwin_386.go src/pkg/syscall/ztypes_darwin_amd64.go had to be edited after the godefs generation. * ztypes_*.go files for linux, freebsd and darwin have been prepared on the correct host OS and ARCH. While the total increase is a dozen lines per file the diff is larger due to a change to godefs, http://code.google.com/p/go/source/detail?r=c79e30afe9c8 while has altered the names of Pad members which causes gofmt to realign the affected structs

Patch Set 1 #

Patch Set 2 : code review 4119053: syscall: add SetsockoptIpMreq #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -176 lines) Patch
M src/pkg/syscall/syscall_bsd.go View 1 chunk +4 lines, -0 lines 1 comment Download
M src/pkg/syscall/syscall_linux.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_darwin.c View 2 chunks +2 lines, -0 lines 2 comments Download
M src/pkg/syscall/types_freebsd.c View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_linux.c View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_386.go View 3 chunks +13 lines, -7 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_amd64.go View 6 chunks +29 lines, -23 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_386.go View 1 3 chunks +8 lines, -2 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_amd64.go View 1 4 chunks +24 lines, -18 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_386.go View 1 5 chunks +61 lines, -55 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_amd64.go View 1 6 chunks +77 lines, -71 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
4 years, 7 months ago (2011-02-03 12:10:54 UTC) #1
mikio
Hi, Today IANA announced that no unicast IPv4/8s remain unallocated. So I'd like to go ...
4 years, 7 months ago (2011-02-03 16:26:49 UTC) #2
rsc
LGTM I understand mikioh's concern, but an even more important one is that the types ...
4 years, 7 months ago (2011-02-03 18:29:33 UTC) #3
rsc
4 years, 7 months ago (2011-02-03 19:15:37 UTC) #4
*** Submitted as 7f8ffd20a14d ***

syscall: add SetsockoptIpMreq

notes:
* due to Issue 1466 the Msghdr struct for
 src/pkg/syscall/ztypes_darwin_386.go
 src/pkg/syscall/ztypes_darwin_amd64.go
had to be edited after the godefs generation.
* ztypes_*.go files for linux, freebsd and darwin
have been prepared on the correct host OS and ARCH.
While the total increase is a dozen lines per file
the diff is larger due to a change to godefs,
 http://code.google.com/p/go/source/detail?r=c79e30afe9c8
while has altered the names of Pad members which
causes gofmt to realign the affected structs

R=rsc, mikioh
CC=golang-dev
http://codereview.appspot.com/4119053

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld fd993c8