Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(742)

Issue 3988043: NS-3 Click Integration (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by Lalith Suresh
Modified:
10 years ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Updated ns-3-click repo #

Patch Set 3 : Updated ns-3-click repo #

Patch Set 4 : Update 3 #

Total comments: 2

Patch Set 5 : Removes Tcp/Udp L4Protocol dependencies #

Patch Set 6 : ns-3-click without tx-queue feedback #

Patch Set 7 : Minor correction to ethertype in promisc mode #

Total comments: 19

Patch Set 8 : Incorporates Mathieu's comments #

Total comments: 8

Patch Set 9 : Incorporates Tom's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4578 lines, -9 lines) Patch
A doc/manual/source/click.rst View 1 chunk +156 lines, -0 lines 0 comments Download
M src/internet-stack/tcp-l4-protocol.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -6 lines 0 comments Download
M src/internet-stack/udp-l4-protocol.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet-stack/wscript View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/node/ipv4.h View 1 2 3 4 5 6 7 8 2 chunks +23 lines, -0 lines 0 comments Download
A src/routing/click/doc/click.h View 1 chunk +106 lines, -0 lines 0 comments Download
src/routing/click/examples/nsclick-ip-router.click View 1 chunk +82 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-lan-single-interface.click View 1 chunk +113 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-raw-wlan.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-routing.cc View 1 chunk +135 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-routing-node0.click View 1 chunk +112 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-routing-node2.click View 1 chunk +112 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-simple-lan.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-udp-client-server-csma.cc View 1 chunk +126 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-udp-client-server-wifi.cc View 1 2 3 4 5 6 7 1 chunk +199 lines, -0 lines 0 comments Download
A src/routing/click/examples/nsclick-wifi-single-interface.click View 1 chunk +113 lines, -0 lines 0 comments Download
A src/routing/click/examples/wscript View 1 chunk +22 lines, -0 lines 0 comments Download
A src/routing/click/helper/click-internet-stack-helper.h View 1 2 3 4 5 6 7 8 1 chunk +230 lines, -0 lines 0 comments Download
A src/routing/click/helper/click-internet-stack-helper.cc View 1 2 3 4 5 6 7 1 chunk +503 lines, -0 lines 0 comments Download
A src/routing/click/model/ipv4-click-routing.h View 1 2 3 4 5 6 7 1 chunk +247 lines, -0 lines 0 comments Download
A src/routing/click/model/ipv4-click-routing.cc View 1 2 3 4 5 6 7 8 1 chunk +646 lines, -0 lines 0 comments Download
A src/routing/click/model/ipv4-l3-click-protocol.h View 1 2 3 4 5 6 7 1 chunk +267 lines, -0 lines 0 comments Download
A src/routing/click/model/ipv4-l3-click-protocol.cc View 1 2 3 4 5 6 7 1 chunk +814 lines, -0 lines 0 comments Download
A src/routing/click/test/ipv4-click-routing-test.cc View 1 chunk +222 lines, -0 lines 0 comments Download
A src/routing/click/waf View 1 chunk +1 line, -0 lines 0 comments Download
A src/routing/click/wscript View 1 2 3 4 5 6 7 1 chunk +93 lines, -0 lines 0 comments Download
M src/wscript View 1 2 3 4 5 4 chunks +3 lines, -1 line 0 comments Download
M test.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Mathieu Lacage
I did not review the click-specific code but I looked at the NetDevice changes and ...
10 years, 2 months ago (2011-01-19 12:07:44 UTC) #1
Ruben Merz
Hi Mathieu, Thanks for the review. I was expecting your comment on having a more ...
10 years, 2 months ago (2011-01-19 12:21:13 UTC) #2
Mathieu Lacage
On Wed, Jan 19, 2011 at 13:21, <ruben.merz@telekom.de> wrote: > Hi Mathieu, > > Thanks ...
10 years, 2 months ago (2011-01-20 11:58:09 UTC) #3
gjcarneiro
On Thu, Jan 20, 2011 at 11:58, Mathieu Lacage <mathieu.lacage@gmail.com>wrote: > On Wed, Jan 19, ...
10 years, 2 months ago (2011-01-20 12:05:22 UTC) #4
Tom Henderson
On 2011/01/19 12:07:44, Mathieu Lacage wrote: > I did not review the click-specific code but ...
10 years, 2 months ago (2011-01-21 20:03:06 UTC) #5
Tom Henderson
> Knowing tom, he would probably say yes. > I would usually say yes but ...
10 years, 2 months ago (2011-01-21 20:04:21 UTC) #6
Tom Henderson
http://codereview.appspot.com/3988043/diff/2002/src/internet-stack/tcp-l4-protocol.cc File src/internet-stack/tcp-l4-protocol.cc (right): http://codereview.appspot.com/3988043/diff/2002/src/internet-stack/tcp-l4-protocol.cc#newcode130 src/internet-stack/tcp-l4-protocol.cc:130: if (!isClickNode) I would prefer to see Send() API ...
10 years, 2 months ago (2011-01-21 20:07:00 UTC) #7
Lalith Suresh
Hello all, I've incorporated Tom's comment which adds a virtual Send() method to the Ipv4 ...
10 years, 2 months ago (2011-01-22 13:55:35 UTC) #8
Mathieu Lacage
josh insisted that I review this so, here it is. http://codereview.appspot.com/3988043/diff/29001/src/internet-stack/tcp-l4-protocol.cc File src/internet-stack/tcp-l4-protocol.cc (right): http://codereview.appspot.com/3988043/diff/29001/src/internet-stack/tcp-l4-protocol.cc#newcode369 ...
10 years, 1 month ago (2011-02-17 14:04:43 UTC) #9
Lalith Suresh
Hello Mathieu, Thanks for the review! I've uploaded a new patch set which incorporates your ...
10 years, 1 month ago (2011-02-17 22:49:19 UTC) #10
Tom Henderson
a few more comments on the latest patchset http://codereview.appspot.com/3988043/diff/35001/src/node/ipv4.h File src/node/ipv4.h (right): http://codereview.appspot.com/3988043/diff/35001/src/node/ipv4.h#newcode147 src/node/ipv4.h:147: * ...
10 years, 1 month ago (2011-02-18 02:06:37 UTC) #11
Mathieu Lacage
On Fri, Feb 18, 2011 at 03:06, <tomh.org@gmail.com> wrote: > http://codereview.appspot.com/3988043/diff/35001/src/routing/click/examples/nsclick-raw-wlan.cc#newcode44 > src/routing/click/examples/nsclick-raw-wlan.cc:44: #ifdef NS3_CLICK ...
10 years, 1 month ago (2011-02-18 09:34:19 UTC) #12
Lalith Suresh
On 2011/02/18 02:06:37, Tom Henderson wrote: > a few more comments on the latest patchset ...
10 years, 1 month ago (2011-02-18 10:51:58 UTC) #13
Tom Henderson
I don't have further comments and support merging it for this release once you believe ...
10 years, 1 month ago (2011-02-18 19:33:26 UTC) #14
Lalith Suresh
10 years, 1 month ago (2011-02-19 09:13:21 UTC) #15
Thanks Tom.

Mathieu? :)

On Fri, Feb 18, 2011 at 7:33 PM, <tomh.org@gmail.com> wrote:

> I don't have further comments and support merging it for this release
> once you believe that all items of concern have been addressed.
>
>
>
>
> http://codereview.appspot.com/3988043/
>



-- 
Lalith Suresh
*Department of Computer Science and Engineering*
*Instituto Superior Técnico*
www.lalith.in
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b