Issue 38670043: code review 38670043: cmd/gc, runtime: correct a misnomer regarding dead valu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 38670043: code review 38670043: cmd/gc, runtime: correct a misnomer regarding dead valu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by cshapiro

Modified:
11 years, 7 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/gc, runtime: correct a misnomer regarding dead value maps The funcdata symbol incorrectly named the dead value map the dead pointer map. The dead value map identifies all dead values, including pointers and non-pointers, in a stack frame. The purpose of this map is to allow the runtime to poison locations of dead data to catch lost invariants.

Patch Set 1 #

Patch Set 2 : diff -r 5298d82f682f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5298d82f682f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5298d82f682f https://code.google.com/p/go/ #

Patch Set 5 : diff -r 5298d82f682f https://code.google.com/p/go/ #

Patch Set 6 : diff -r 3dbc26e90c59 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
M	src/cmd/gc/pgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/plive.c	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/runtime/funcdata.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

cshapiro

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-12-07 01:25:59 UTC) #1

cshapiro

11 years, 7 months ago (2013-12-09 22:45:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4a286c9bbfce ***

cmd/gc, runtime: correct a misnomer regarding dead value maps

The funcdata symbol incorrectly named the dead value map the
dead pointer map.  The dead value map identifies all dead
values, including pointers and non-pointers, in a stack frame.
The purpose of this map is to allow the runtime to poison
locations of dead data to catch lost invariants.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/38670043

Expand All Messages | Collapse All Messages