Issue 38650043: code review 38650043: cmd/gc: do not generate dead value maps yet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 38650043: code review 38650043: cmd/gc: do not generate dead value maps yet (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by cshapiro

Modified:
11 years, 7 months ago

Reviewers:
iant

CC:
golang-dev, iant, cshapiro1

Visibility:
Public.

Description

cmd/gc: do not generate dead value maps yet We are not clearing dead values in the garbage collector so it is not worth the RSS cost to materialize the data and write it out to the binary.

Patch Set 2 : diff -r 56e413ce0289 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 56e413ce0289 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 31bb8d7e107d https://code.google.com/p/go/ #

Patch Set 5 : diff -r 31bb8d7e107d https://code.google.com/p/go/ #

Patch Set 6 : diff -r 31bb8d7e107d https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/cmd/gc/pgen.c	View	1 2 3 4 5	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

cshapiro

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-12-06 23:08:43 UTC) #1

iant

LGTM https://codereview.appspot.com/38650043/diff/40001/src/cmd/gc/pgen.c File src/cmd/gc/pgen.c (right): https://codereview.appspot.com/38650043/diff/40001/src/cmd/gc/pgen.c#newcode156 src/cmd/gc/pgen.c:156: if(0) Perhaps a comment? /* Don't build gcdead ...

11 years, 7 months ago (2013-12-06 23:37:19 UTC) #2

cshapiro1

https://codereview.appspot.com/38650043/diff/40001/src/cmd/gc/pgen.c File src/cmd/gc/pgen.c (right): https://codereview.appspot.com/38650043/diff/40001/src/cmd/gc/pgen.c#newcode156 src/cmd/gc/pgen.c:156: if(0) Good idea. I've added a comment with some ...

11 years, 7 months ago (2013-12-06 23:44:51 UTC) #3

cshapiro

11 years, 7 months ago (2013-12-06 23:49:50 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=5298d82f682f ***

cmd/gc: do not generate dead value maps yet

We are not clearing dead values in the garbage collector so it
is not worth the RSS cost to materialize the data and write it
out to the binary.

R=golang-dev, iant, cshapiro
CC=golang-dev
https://codereview.appspot.com/38650043

Expand All Messages | Collapse All Messages