Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 38290044: code review 38290044: crypto/tls: generate random serial numbers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by agl1
Modified:
10 years, 3 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

crypto/tls: generate random serial numbers. NSS (used in Firefox and Chrome) won't accept two certificates with the same issuer and serial. But this causes problems with self-signed certificates with a fixed serial number. This change randomises the serial numbers in the certificates generated by generate_cert.go.

Patch Set 1 #

Patch Set 2 : diff -r c37a24ac952c https://code.google.com/p/go/ #

Patch Set 3 : diff -r c37a24ac952c https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r d2e5012b1bdd https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/pkg/crypto/tls/generate_cert.go View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 3 months ago (2013-12-14 16:00:05 UTC) #1
r
LGTM https://codereview.appspot.com/38290044/diff/40001/src/pkg/crypto/tls/generate_cert.go File src/pkg/crypto/tls/generate_cert.go (right): https://codereview.appspot.com/38290044/diff/40001/src/pkg/crypto/tls/generate_cert.go#newcode72 src/pkg/crypto/tls/generate_cert.go:72: return this return isn't necessary.
10 years, 3 months ago (2013-12-14 16:08:04 UTC) #2
agl1
10 years, 3 months ago (2013-12-15 17:58:08 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=4ce5fd769c69 ***

crypto/tls: generate random serial numbers.

NSS (used in Firefox and Chrome) won't accept two certificates with the same
issuer and serial. But this causes problems with self-signed certificates
with a fixed serial number.

This change randomises the serial numbers in the certificates generated by
generate_cert.go.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/38290044

https://codereview.appspot.com/38290044/diff/40001/src/pkg/crypto/tls/generat...
File src/pkg/crypto/tls/generate_cert.go (right):

https://codereview.appspot.com/38290044/diff/40001/src/pkg/crypto/tls/generat...
src/pkg/crypto/tls/generate_cert.go:72: return
On 2013/12/14 16:08:05, r wrote:
> this return isn't necessary.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b