Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)

Issue 37880044: code review 37880044: gosshnew/ssh/agent: fix test for ssh.Conn reorganization. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by hanwen-google
Modified:
10 years, 3 months ago
Reviewers:
jpsugar
CC:
agl1, dfc, jpsugar, golang-dev, hanwen-google
Visibility:
Public.

Description

gosshnew/ssh/agent: fix test for ssh.Conn reorganization.

Patch Set 1 #

Patch Set 2 : diff -r c49c1e57bc09 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 3 : diff -r c49c1e57bc09 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 4 : diff -r c8e1e80a995c https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ssh/agent/agent_test.go View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3
hanwen-google
Hello agl1, dfc, jpsugar@google.com (cc: agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com, jpsugar@google.com), I'd like you to review ...
10 years, 3 months ago (2013-12-13 15:25:26 UTC) #1
jpsugar
LGTM
10 years, 3 months ago (2013-12-13 18:51:04 UTC) #2
hanwen-google
10 years, 3 months ago (2013-12-13 19:35:04 UTC) #3
*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=50cb6fe1f935
***

gosshnew/ssh/agent: fix test for ssh.Conn reorganization.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/37880044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b