Change \partcombine (et al.) to \partCombine

Change \partcombine (et al.) to \partCombine

I figured I’d try and rebase/update/complete Charles’ previous
proposal in case someone ever decides to apply it.
In which case, I guess \autochange should be updated as well;
that’s the only other multi-word command I could find that
had’nt been previously camelCased as part of Graham’s
`Grand Syntax Stabilization’ project a few years back.

… Well, unless you count \defaultchild and \grobdescriptions,
but that’s not something the average user tends to be exposed to.

Then again, for some reason we do still have \fontsize and
\normalsize, all lower-case (camelCase being precisely what
sets apart fontSize, as a property, from \fontsize as a command).

I personally don’t have more than a slight preference towards
\partCombine and \autoChange, and I wouldn’t dare to guess
how much damage this syntax break could cause (though my
we’ve definitely seen worse in the past, this one being
fairly trivially handled by convert-ly).

And, yes, I’m well aware that there still are much bigger
fishes to fry at the moment (but that’s already what
got the \partcombine patch stuck in limbo last year).

[Valentin Villenave, 2018-12-16 14:31:45]

Revamped patch. Passes make & makedoc; adds \autoChange.

[dak, 2018-12-21 11:22:21]

https://codereview.appspot.com/369930043/diff/20001/python/convertrules.py
File python/convertrules.py (right):

https://codereview.appspot.com/369930043/diff/20001/python/convertrules.py#ne...
python/convertrules.py:3977: str = re.sub (r"\\partcombine", r"\\partCombine",
str)
Uh, you realize that every line after this one is a no-op?

[Valentin Villenave, 2018-12-21 17:50:33]

Correct convert rules.

[Valentin Villenave, 2018-12-28 09:43:58]

On 2018/12/21 17:50:33, Valentin Villenave wrote:
> Correct convert rules.

OK, pushed onto staging as 72067b395d947f1349ab8010f0592d45e52b8141.

[Malte Meyn, 2018-12-28 11:11:50]

On 2018/12/28 09:43:58, Valentin Villenave wrote:
> On 2018/12/21 17:50:33, Valentin Villenave wrote:
> > Correct convert rules.
> 
> OK, pushed onto staging as 72067b395d947f1349ab8010f0592d45e52b8141.

I think you should change the sourceforge issue
(https://sourceforge.net/p/testlilyissues/issues/4603/):
• click “Edit” at the top right
• set “Status” to “Fixed”
• unset “Patch”
• set “Labels” to “Fixed_2_21_0”
• mention the commit in the comment section at the bottom and click “Save”

[pkx166h_runbox.com, 2018-12-29 10:40:36]

Valentin,

On 28/12/2018 11:11 am, lilypond@maltemeyn.de wrote:
> On 2018/12/28 09:43:58, Valentin Villenave wrote:
>> On 2018/12/21 17:50:33, Valentin Villenave wrote:
>> > Correct convert rules.
>
>> OK, pushed onto staging as 72067b395d947f1349ab8010f0592d45e52b8141.
>
> I think you should change the sourceforge issue
> (https://sourceforge.net/p/testlilyissues/issues/4603/):
> • click “Edit” at the top right
> • set “Status” to “Fixed”
> • unset “Patch”
> • set “Labels” to “Fixed_2_21_0”
> • mention the commit in the comment section at the bottom and click
> “Save”

I did this for you as I was checking all the current trackers/Rietvelds 
anyway.


James