Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 369880043: Add warning about surrounding gsutil args with # in them with quotes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 3 weeks ago by Mike Schwartz
Modified:
1 month, 2 weeks ago
Reviewers:
yarbrough, houglum, nstock
CC:
gsutil-crs_google.com
Visibility:
Public.

Description

Add warning about surrounding gsutil args with # in them with quotes

Patch Set 1 #

Total comments: 2

Patch Set 2 : expand on wildcard problems #

Patch Set 3 : fix long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gslib/addlhelp/wildcards.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
Mike Schwartz
1 month, 3 weeks ago (2018-10-17 21:39:13 UTC) #1
Mike Schwartz
see b/117876221 for background
1 month, 3 weeks ago (2018-10-17 21:39:31 UTC) #2
Mike Schwartz
ping? I think we should update gsutil built-in help about this issue, in addition to ...
1 month, 2 weeks ago (2018-10-22 16:11:20 UTC) #3
houglum
https://codereview.appspot.com/369880043/diff/1/gslib/addlhelp/versions.py File gslib/addlhelp/versions.py (right): https://codereview.appspot.com/369880043/diff/1/gslib/addlhelp/versions.py#newcode123 gslib/addlhelp/versions.py:123: Note also that some shells treat "#" as a ...
1 month, 2 weeks ago (2018-10-22 21:40:32 UTC) #4
Mike Schwartz
https://codereview.appspot.com/369880043/diff/1/gslib/addlhelp/versions.py File gslib/addlhelp/versions.py (right): https://codereview.appspot.com/369880043/diff/1/gslib/addlhelp/versions.py#newcode123 gslib/addlhelp/versions.py:123: Note also that some shells treat "#" as a ...
1 month, 2 weeks ago (2018-10-22 22:17:18 UTC) #5
houglum
1 month, 2 weeks ago (2018-10-22 23:04:53 UTC) #6
LGTM! Thanks, Mike.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b