Issue 369880043: Add warning about surrounding gsutil args with # in them with quotes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 369880043: Add warning about surrounding gsutil args with # in them with quotes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 6 months ago by Mike Schwartz

Modified:
5 years, 6 months ago

Reviewers:
yarbrough, houglum, nstock

CC:
gsutil-crs_google.com

Visibility:
Public.

More Reviews

Description

Add warning about surrounding gsutil args with # in them with quotes

Patch Set 2 : expand on wildcard problems #

Patch Set 3 : fix long line #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	gslib/addlhelp/wildcards.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Mike Schwartz

ping? I think we should update gsutil built-in help about this issue, in addition to ...

5 years, 6 months ago (2018-10-22 16:11:20 UTC) #3

houglum

https://codereview.appspot.com/369880043/diff/1/gslib/addlhelp/versions.py File gslib/addlhelp/versions.py (right): https://codereview.appspot.com/369880043/diff/1/gslib/addlhelp/versions.py#newcode123 gslib/addlhelp/versions.py:123: Note also that some shells treat "#" as a ...

5 years, 6 months ago (2018-10-22 21:40:32 UTC) #4

Mike Schwartz

5 years, 6 months ago (2018-10-22 22:17:18 UTC) #5

LGTM! Thanks, Mike.

Expand All Messages | Collapse All Messages