Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 369840043: issue 5413: X-aligning problem with chords containing unisons

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Be-3
Modified:
2 months, 1 week ago
Reviewers:
carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue 5413: X-aligning problem with chords containing unisons Changes to be committed: modified: ../lily/stem.cc Stem::extremal_heads - To avoid confusion, process noteheads in <> from left to right - lowest note: return FIRST unison note (punctum saliens!) - highest note: return LAST unison note Separate DOWN/UP processing now (because of < vs. >=). Result: consistent spacing plus correct first/last/main notehead detection. new file: ../input/regression/chord-X-align-on-main-noteheads.ly - Regression test added

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
A input/regression/chord-X-align-on-main-noteheads.ly View 1 chunk +14 lines, -0 lines 0 comments Download
M lily/stem.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 2
Be-3
Please review. Thanks, Torsten
2 months, 1 week ago (2018-09-05 20:05:12 UTC) #1
Carl
2 months, 1 week ago (2018-09-10 17:39:24 UTC) #2
LGTM.

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b