Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1457)

Issue 3693042: Fix 1456 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by Carl
Modified:
8 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1456 Eliminate the context argument from \overrideTimeSignatureSettings and \revertTimeSignatureSettings, since the settings that apply must be those from the Timing context. Update documentation to go along with this change. Run convert-ly on the docs and snippets.

Patch Set 1 #

Total comments: 17

Patch Set 2 : Respond to comments #

Total comments: 8

Patch Set 3 : Respond to Patrick's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -71 lines) Patch
M Documentation/de/notation/rhythms.itely View 3 chunks +2 lines, -4 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 3 chunks +2 lines, -4 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 3 chunks +2 lines, -4 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 2 4 chunks +91 lines, -20 lines 0 comments Download
M input/regression/multiple-time-sig-settings.ly View 1 2 chunks +16 lines, -16 lines 0 comments Download
M input/regression/skiptypesetting-multimeasurerest.ly View 1 1 chunk +0 lines, -1 line 0 comments Download
M ly/music-functions-init.ly View 1 2 chunks +8 lines, -8 lines 0 comments Download
M python/convertrules.py View 1 chunk +6 lines, -0 lines 0 comments Download
M scm/time-signature-settings.scm View 1 3 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 11
Carl
Here's a fix for issue 1456. I've taken the context argument out of \overrideTimeSignatureSettings and ...
8 years, 8 months ago (2010-12-16 23:10:35 UTC) #1
Graham Percival (old account)
Looks fine from a quick eyeball, but I haven't tested it. We've had a few ...
8 years, 8 months ago (2010-12-17 13:53:06 UTC) #2
Graham Percival (old account)
oops, I hit "reply to comment" intead of "publish+send". Here's my only comment on the ...
8 years, 8 months ago (2010-12-17 13:53:37 UTC) #3
mail_philholmes.net
----- Original Message ----- From: <percival.music.ca@gmail.com> To: <Carl.D.Sorensen@gmail.com> Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Friday, December 17, ...
8 years, 8 months ago (2010-12-17 16:57:42 UTC) #4
mikesol_ufl.edu
Tested and nothing broke. Let me know if you want me to send any output. ...
8 years, 8 months ago (2010-12-17 20:49:18 UTC) #5
Neil Puttock
http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (left): http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely#oldcode1059 Documentation/notation/rhythms.itely:1059: \relative c' { \new Staff http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely#oldcode1106 Documentation/notation/rhythms.itely:1106: \relative c' ...
8 years, 8 months ago (2010-12-17 22:37:36 UTC) #6
Carl
Thanks for the excellent feedback. I've fixed everything now. A revised patch set is available. ...
8 years, 8 months ago (2010-12-18 00:27:46 UTC) #7
Neil Puttock
LGTM.
8 years, 8 months ago (2010-12-19 16:54:17 UTC) #8
pkx166h
Just some Nitpicks http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1111 Documentation/notation/rhythms.itely:1111: c8^\markup "Beamed (2 2)" \repeat unfold ...
8 years, 8 months ago (2010-12-20 01:20:30 UTC) #9
Carl
Thanks for the review, Patrick. I've made the changes and posted a new patch set. ...
8 years, 8 months ago (2010-12-20 05:49:39 UTC) #10
Graham Percival (old account)
8 years, 8 months ago (2010-12-20 18:39:19 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b