Issue 367870043: Issue 5428: Avoid type-conversion warnings related to font glyph index

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 367870043: Issue 5428: Avoid type-conversion warnings related to font glyph index (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 6 months ago by Dan Eble

Modified:
5 years, 5 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Also, in a separate commit, fix a warning about long-to-double conversion of font revision. Warnings were observed with g++ 8.2.0 on x86_64. https://sourceforge.net/p/testlilyissues/issues/5428/

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -18 lines)			Patch
M	lily/font-metric.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lily/font-metric-scheme.cc	View	2 chunks	+9 lines, -2 lines	0 comments	Download
M	lily/include/font-metric.hh	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lily/note-head.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lily/open-type-font.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	lily/pango-font.cc	View	2 chunks	+17 lines, -6 lines	0 comments	Download
M	lily/ttf.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download