Add IBUS_CAP_AUTO_COMMIT flag for web browser client

Add IBUS_CAP_AUTO_COMMIT flag for web browser client

Firefox can auto commit the preedit text without input method.
Add IBUS_CAP_AUTO_COMMIT flag for Firefox client,
ibus-hangul can check this flag to not commit the preedit text again.

BUG=https://github.com/ibus/ibus/issues/1980

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=867433

[Peng Wu, 2018-08-30 07:39:56]

Please review the patch, thanks!

[Peng Wu, 2018-08-30 07:45:13]

FYI, https://github.com/libhangul/ibus-hangul/pull/68 .

[fujiwara, 2018-08-30 08:03:42]

On 2018/08/30 07:45:13, Peng Wu wrote:
> FYI, https://github.com/libhangul/ibus-hangul/pull/68 .

My understanding is ibus-hangul will use IBUS_CAP_AUTO_COMMIT but I think
whether ibus-hangul does not commit preedit or not, the bug is not fixed.
ibus needs to move the logic in preedit mode in ibus-daemon to ibus client as I
described the patches.

Note: the bug is not firefox only but all GTK applications.

[Peng Wu, 2018-10-24 07:11:46]

On 2018/08/30 08:03:42, fujiwara wrote:
> On 2018/08/30 07:45:13, Peng Wu wrote:
> > FYI, https://github.com/libhangul/ibus-hangul/pull/68 .
> 
> My understanding is ibus-hangul will use IBUS_CAP_AUTO_COMMIT but I think
> whether ibus-hangul does not commit preedit or not, the bug is not fixed.
> ibus needs to move the logic in preedit mode in ibus-daemon to ibus client as
I
> described the patches.
> 
> Note: the bug is not firefox only but all GTK applications.

I think Firefox and Gtk+ Applications are different.

Both Firefox and Chrome already have some code for auto committing when mouse
clicking, and Chrome will ignore the ibus-hangul preedit commit.

With this patch, ibus-hangul will not send the preedit commit to Firefox,
because Firefox already commit the preedit commit similar like Chrome.

Maybe Gtk+ applications can also support the auto committing feature in future.

[fujiwara, 2018-10-24 07:30:24]

On 2018/10/24 07:11:46, Peng Wu wrote:
> On 2018/08/30 08:03:42, fujiwara wrote:
> > On 2018/08/30 07:45:13, Peng Wu wrote:
> > > FYI, https://github.com/libhangul/ibus-hangul/pull/68 .
> > 
> > My understanding is ibus-hangul will use IBUS_CAP_AUTO_COMMIT but I think
> > whether ibus-hangul does not commit preedit or not, the bug is not fixed.
> > ibus needs to move the logic in preedit mode in ibus-daemon to ibus client
as
> I
> > described the patches.
> > 
> > Note: the bug is not firefox only but all GTK applications.
> 
> I think Firefox and Gtk+ Applications are different.
> 
> Both Firefox and Chrome already have some code for auto committing when mouse
> clicking, and Chrome will ignore the ibus-hangul preedit commit.
> 
> With this patch, ibus-hangul will not send the preedit commit to Firefox,
> because Firefox already commit the preedit commit similar like Chrome.
> 
> Maybe Gtk+ applications can also support the auto committing feature in
future.

Probably I think it's better to handle to commit, clear or keep in ibus and I
assume always enabling the commit only would be a bug in firefox and chrome.

Also ibus already provides ibus_engine_update_preedit_text_with_mode() and I
think the environment variables are not so useful for the engine settings but
not user settings.