Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 367850043: Add IBUS_CAP_AUTO_COMMIT flag for web browser client

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by Peng Wu
Modified:
2 weeks, 6 days ago
Reviewers:
shawn.p.huang, fujiwara
Visibility:
Public.

Description

Add IBUS_CAP_AUTO_COMMIT flag for web browser client Firefox can auto commit the preedit text without input method. Add IBUS_CAP_AUTO_COMMIT flag for Firefox client, ibus-hangul can check this flag to not commit the preedit text again. BUG=https://github.com/ibus/ibus/issues/1980 URL: https://bugzilla.mozilla.org/show_bug.cgi?id=867433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M client/gtk2/ibusimcontext.c View 3 chunks +13 lines, -0 lines 0 comments Download
M src/ibustypes.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Peng Wu
Please review the patch, thanks!
2 weeks, 6 days ago (2018-08-30 07:39:56 UTC) #1
Peng Wu
FYI, https://github.com/libhangul/ibus-hangul/pull/68 .
2 weeks, 6 days ago (2018-08-30 07:45:13 UTC) #2
fujiwara
2 weeks, 6 days ago (2018-08-30 08:03:42 UTC) #3
On 2018/08/30 07:45:13, Peng Wu wrote:
> FYI, https://github.com/libhangul/ibus-hangul/pull/68 .

My understanding is ibus-hangul will use IBUS_CAP_AUTO_COMMIT but I think
whether ibus-hangul does not commit preedit or not, the bug is not fixed.
ibus needs to move the logic in preedit mode in ibus-daemon to ibus client as I
described the patches.

Note: the bug is not firefox only but all GTK applications.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b