Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1156)

Issue 367720043: Address problem where seek_ahead_iterator races with commands being run, resulting in errors being … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by Mike Schwartz
Modified:
1 month, 3 weeks ago
Reviewers:
thobrla
CC:
houglum, gsutil-crs_google.com, dshorten
Visibility:
Public.

Description

Address problem where seek_ahead_iterator races with commands being run, resulting in errors being …

Patch Set 1 #

Total comments: 12

Patch Set 2 : Changes per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M gslib/seek_ahead_thread.py View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12
Mike Schwartz
This addresses b/77655855
2 months, 3 weeks ago (2018-06-27 16:19:47 UTC) #1
thobrla
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. Catching this exception here ...
2 months, 3 weeks ago (2018-06-27 20:43:55 UTC) #2
Mike Schwartz
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/27 20:43:54, thobrla ...
2 months, 3 weeks ago (2018-06-27 20:56:24 UTC) #3
thobrla
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/27 20:56:24, Mike ...
2 months, 3 weeks ago (2018-06-27 22:01:50 UTC) #4
Mike Schwartz
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/27 22:01:48, thobrla ...
2 months, 3 weeks ago (2018-06-28 20:00:07 UTC) #5
thobrla
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/28 20:00:07, Mike ...
2 months, 3 weeks ago (2018-06-28 20:14:03 UTC) #6
Mike Schwartz
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/28 20:14:03, thobrla ...
2 months, 3 weeks ago (2018-06-28 20:20:41 UTC) #7
thobrla
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/28 20:20:41, Mike ...
2 months, 3 weeks ago (2018-06-28 20:24:12 UTC) #8
Mike Schwartz
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/28 20:24:12, thobrla ...
2 months, 3 weeks ago (2018-06-28 20:37:47 UTC) #9
thobrla
https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/28 20:37:47, Mike ...
2 months, 3 weeks ago (2018-06-29 16:09:26 UTC) #10
Mike Schwartz
PTAL https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py File gslib/seek_ahead_thread.py (right): https://codereview.appspot.com/367720043/diff/1/gslib/seek_ahead_thread.py#newcode112 gslib/seek_ahead_thread.py:112: # operations, so ignore it. On 2018/06/29 16:09:26, ...
2 months, 3 weeks ago (2018-06-29 16:27:25 UTC) #11
thobrla
2 months, 3 weeks ago (2018-06-29 16:31:30 UTC) #12
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b