Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2635)

Issue 365770043: Spanner::substitute_one_mutable_property: don't copy `this'

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by dak
Modified:
4 months, 2 weeks ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Spanner::substitute_one_mutable_property: don't copy `this' Also contains commit: break-substitution.cc: typo fix 'subsititution'

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -33 lines) Patch
M lily/break-substitution.cc View 3 chunks +28 lines, -33 lines 0 comments Download

Messages

Total messages: 1
Dan Eble
4 months, 2 weeks ago (2018-07-25 22:10:09 UTC) #1
To David: LGTM.

To whomever decided that lowercase L would be a good variable name: please,
never do it again.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b