Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4767)

Issue 363930043: Do not build PDFs from the website Texinfo sources

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by John Mandereau
Modified:
5 years, 1 month ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Do not build PDFs from the website Texinfo sources These PDF documents were not linked from the website or the documentation in HTML format, and they also had formatting issues, e.g. bitmaps too large to fit in the page width.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use better variable names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Documentation/GNUmakefile View 1 1 chunk +2 lines, -1 line 0 comments Download
M make/doc-i18n-root-vars.make View 1 1 chunk +2 lines, -1 line 0 comments Download
M stepmake/stepmake/texinfo-vars.make View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
lemzwerg
https://codereview.appspot.com/363930043/diff/1/Documentation/GNUmakefile File Documentation/GNUmakefile (right): https://codereview.appspot.com/363930043/diff/1/Documentation/GNUmakefile#newcode54 Documentation/GNUmakefile:54: TEXINFO_MANUALS_BUT_WEB = $(filter-out web,$(TEXINFO_MANUALS)) LGTM except this variable name. ...
5 years, 1 month ago (2019-02-21 23:19:53 UTC) #1
John Mandereau
Werner LEMBERG wrote: > https://codereview.appspot.com/363930043/diff/1/Documentation/GNUmake > file#newcode54 > Documentation/GNUmakefile:54: TEXINFO_MANUALS_BUT_WEB > = $(filter-out > web,$(TEXINFO_MANUALS)) ...
5 years, 1 month ago (2019-02-24 20:04:13 UTC) #2
lemzwerg
> What about "TEXINFO_MANUALS_WITHOUT_WEB"? IMHO this is much better.
5 years, 1 month ago (2019-02-24 20:17:24 UTC) #3
John Mandereau
Le dimanche 24 février 2019 à 21:04 +0100, John Mandereau a écrit : > Werner ...
5 years, 1 month ago (2019-02-24 22:09:05 UTC) #4
John Mandereau
Use better variable names
5 years, 1 month ago (2019-02-28 21:41:08 UTC) #5
John Mandereau
5 years, 1 month ago (2019-03-01 07:34:58 UTC) #6
Le dim. 24 févr. 2019 à 23:09, John Mandereau <john.mandereau@gmail.com> a
écrit :

> > What about "TEXINFO_MANUALS_WITHOUT_WEB"?
>
> To make the contest a little bit more interesting, what about the
> following ones?
>
> NON_WEBSITE_TEXINFO_MANUALS
> TEXINFO_MANUALS_WITHOUT_WEBSITE
>

I uploaded a new patchset using NOT_WEBSITE_TEXINFO_MANUALS:
https://codereview.appspot.com/363930043/#ps20001
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b