Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(673)

Unified Diff: python/convertrules.py

Issue 363880043: Chord names clean-up; no more Banter, exceptionsPartial or \powerChords. (Closed)
Patch Set: OK, let’s not create a new @rlsr section just yet. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ly/property-init.ly ('k') | scm/chord-generic-names.scm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: python/convertrules.py
diff --git a/python/convertrules.py b/python/convertrules.py
index b80555a5b6880120ce136cef81788dc92df6d0e7..46ef13be2922b6dede8795990ec3e946c6f6f846 100644
--- a/python/convertrules.py
+++ b/python/convertrules.py
@@ -3935,7 +3935,9 @@ matchscmarg = (r'(?:[a-zA-Z_][-a-zA-Z_0-9]*|"(?:[^\\"]|\\.)*"|[-+]?[0-9.]+|\('
@rule ((2, 21, 0), r"""\note #"4." -> \note {4.}
\markup-command #" -> \markup-command "
-\partcombine* -> \partCombine, \autochange -> \autoChange""")
+\partcombine* -> \partCombine, \autochange -> \autoChange
+remove \\powerChords, deprecate banter-chord-names and jazz-chord-names
+""")
def conv (str):
def repl1ly (m):
if m.group (2)[0] in "blm":
@@ -3974,8 +3976,13 @@ def conv (str):
str = re.sub (r"\\partcombine(Force|Up|Down|Chords|Apart|Unisono|SoloI|SoloII|Automatic|)\b",
r"\\partCombine\1", str)
str = re.sub (r"\\autochange", r"\\autoChange", str)
+ str = re.sub (r'\\powerChords', '', str)
+ if re.search (r"#[banter|jazz]-chord-names", str):
dak 2020/01/07 22:06:51 I have no idea what this regexp is actually suppos
+ stderr_write (NOT_SMART % "alternative chord naming functions")
+ stderr_write (UPDATE_MANUALLY)
return str
+
# Guidelines to write rules (please keep this at the end of this file)
#
# - keep at most one rule per version; if several conversions should be done,
« no previous file with comments | « ly/property-init.ly ('k') | scm/chord-generic-names.scm » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b