Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2816)

Issue 363750043: Simplify ly_symbol2scm

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by dak
Modified:
4 months, 1 week ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Simplify ly_symbol2scm

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use ?: since it streamlines the assignment maze #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M lily/include/lily-guile-macros.hh View 1 1 chunk +11 lines, -17 lines 0 comments Download

Messages

Total messages: 4
Dan Eble
https://codereview.appspot.com/363750043/diff/1/lily/include/lily-guile-macros.hh File lily/include/lily-guile-macros.hh (right): https://codereview.appspot.com/363750043/diff/1/lily/include/lily-guile-macros.hh#newcode95 lily/include/lily-guile-macros.hh:95: value; \ This is new to me. It is ...
4 months, 1 week ago (2018-08-04 12:49:43 UTC) #1
dak
https://codereview.appspot.com/363750043/diff/1/lily/include/lily-guile-macros.hh File lily/include/lily-guile-macros.hh (right): https://codereview.appspot.com/363750043/diff/1/lily/include/lily-guile-macros.hh#newcode95 lily/include/lily-guile-macros.hh:95: value; \ On 2018/08/04 12:49:42, Dan Eble wrote: > ...
4 months, 1 week ago (2018-08-04 14:06:51 UTC) #2
dak
Use ?: since it streamlines the assignment maze
4 months, 1 week ago (2018-08-04 15:15:42 UTC) #3
Dan Eble
4 months, 1 week ago (2018-08-05 01:21:00 UTC) #4
On 2018/08/04 15:15:42, dak wrote:
> Use ?: since it streamlines the assignment maze

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b