Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(275)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 36040043: code review 36040043: all: add solaris build tags

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by aram
Modified:
10 years, 3 months ago
Reviewers:
minux1, rsc, dave
CC:
golang-codereviews, minux1, gobot, rsc, dave_cheney.net
Visibility:
Public.

Description

all: add solaris build tags

Patch Set 1 #

Patch Set 2 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 3 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 4 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 5 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 6 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 7 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 8 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 9 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 10 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 11 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 12 : diff -r d45af824172f https://code.google.com/p/go #

Total comments: 2

Patch Set 13 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 14 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 15 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 16 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 17 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Patch Set 18 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/cmd/go/signal_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/tar/stat_atim.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/tar/stat_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/rand/rand_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/x509/root_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/mime/type_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/path/filepath/path_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/sys_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/zoneinfo_unix.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
aram
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2013-12-10 20:41:10 UTC) #1
minux1
LGTM modulo this comment. https://codereview.appspot.com/36040043/diff/220001/src/pkg/log/syslog/syslog_unix.go File src/pkg/log/syslog/syslog_unix.go (right): https://codereview.appspot.com/36040043/diff/220001/src/pkg/log/syslog/syslog_unix.go#newcode5 src/pkg/log/syslog/syslog_unix.go:5: // +build !windows,!plan9 solaris I ...
10 years, 4 months ago (2013-12-13 07:04:29 UTC) #2
gobot
R=rsc@golang.org (assigned by rsc@google.com)
10 years, 4 months ago (2013-12-20 01:57:11 UTC) #3
gobot
Replacing golang-dev with golang-codereviews.
10 years, 4 months ago (2013-12-20 16:26:10 UTC) #4
aram
https://codereview.appspot.com/36040043/diff/220001/src/pkg/log/syslog/syslog_unix.go File src/pkg/log/syslog/syslog_unix.go (right): https://codereview.appspot.com/36040043/diff/220001/src/pkg/log/syslog/syslog_unix.go#newcode5 src/pkg/log/syslog/syslog_unix.go:5: // +build !windows,!plan9 solaris > I think solaris is ...
10 years, 4 months ago (2013-12-21 21:43:40 UTC) #5
aram
Hello golang-codereviews@googlegroups.com, minux.ma@gmail.com, gobot@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 4 months ago (2013-12-21 21:49:30 UTC) #6
dave_cheney.net
On 2013/12/21 21:49:30, aram wrote: > Hello mailto:golang-codereviews@googlegroups.com, mailto:minux.ma@gmail.com, mailto:gobot@golang.org, > mailto:rsc@golang.org (cc: mailto:golang-codereviews@googlegroups.com), > ...
10 years, 4 months ago (2013-12-22 03:33:50 UTC) #7
gobot
R=rsc@golang.org (assigned by olingcat@gmail.com)
10 years, 4 months ago (2013-12-28 01:10:02 UTC) #8
aram
Hello golang-codereviews@googlegroups.com, minux.ma@gmail.com, gobot@golang.org, rsc@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 4 months ago (2013-12-29 17:45:49 UTC) #9
rsc
LGTM
10 years, 3 months ago (2014-01-07 01:49:16 UTC) #10
rsc
10 years, 3 months ago (2014-01-08 04:53:36 UTC) #11 
*** Submitted as https://code.google.com/p/go/source/detail?r=65a1b6a436af ***

all: add solaris build tags

R=golang-codereviews, minux.ma, gobot, rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/36040043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b