Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(251)

Issue 3590041: harmonics and slides

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by pls
Modified:
4 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

harmonics and slides NR-harmonics-and-slides fretted-strings.itely: Documentation of new harmonic functions (\harmonicByFret and \harmonicByRatio). New snippet for slides (glissandi). Added warning that \hideNotes/\unHideNotes cannot be used in tablatures.

Patch Set 1 #

Total comments: 5

Patch Set 2 : revised version of the documentation of harmonics and slides. Added selected snippets. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1411 lines, -724 lines) Patch
M Documentation/notation/fretted-strings.itely View 1 3 chunks +74 lines, -9 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 1 chunk +9 lines, -0 lines 1 comment Download
A Documentation/snippets/new/tablature-fretted-string-harmonics.ly View 1 1 chunk +72 lines, -0 lines 0 comments Download
A Documentation/snippets/new/tablature-open-string-harmonics.ly View 1 1 chunk +62 lines, -0 lines 0 comments Download
A Documentation/snippets/new/tablature-slides.ly View 1 1 chunk +38 lines, -0 lines 0 comments Download
M lily/optimal-page-breaking.cc View 1 1 chunk +1 line, -4 lines 1 comment Download
M lily/page-breaking.cc View 1 1 chunk +3 lines, -0 lines 1 comment Download
M ly/property-init.ly View 1 2 chunks +2 lines, -0 lines 0 comments Download
M po/de.po View 1 39 chunks +1150 lines, -711 lines 0 comments Download

Messages

Total messages: 13
Graham Percival (old account)
Looks basically good. http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely#newcode383 Documentation/notation/fretted-strings.itely:383: @noindent Please remove all the @noindents. ...
8 years, 6 months ago (2010-12-11 16:16:02 UTC) #1
Carl
Looks pretty good to me. Looks *excellent* for a first patch. Thanks, Carl http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely File ...
8 years, 6 months ago (2010-12-11 16:34:00 UTC) #2
pls
Am 11.12.2010 um 17:34 schrieb Carl.D.Sorensen@gmail.com: > Looks pretty good to me. Looks *excellent* for ...
8 years, 6 months ago (2010-12-11 16:54:29 UTC) #3
c_sorensen
On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote: > > > Am 11.12.2010 um 17:34 ...
8 years, 6 months ago (2010-12-11 17:03:53 UTC) #4
pls
Am 11.12.2010 um 18:03 schrieb Carl Sorensen: > On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> ...
8 years, 6 months ago (2010-12-11 19:44:21 UTC) #5
c_sorensen
On 12/11/10 12:44 PM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote: > > > Am 11.12.2010 um 18:03 ...
8 years, 6 months ago (2010-12-11 19:55:50 UTC) #6
c_sorensen
On 12/11/10 12:55 PM, "Carl Sorensen" <c_sorensen@byu.edu> wrote: > > > > On 12/11/10 12:44 ...
8 years, 6 months ago (2010-12-11 20:16:25 UTC) #7
pls
Am 11.12.2010 um 21:16 schrieb Carl Sorensen: > On 12/11/10 12:55 PM, "Carl Sorensen" <c_sorensen@byu.edu> ...
8 years, 6 months ago (2010-12-11 20:35:53 UTC) #8
c_sorensen
On 12/11/10 1:35 PM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote: > > > Am 11.12.2010 um 21:16 ...
8 years, 6 months ago (2010-12-11 20:41:43 UTC) #9
Graham Percival (old account)
It looks like there's lots of good work in this patch, but the latest version ...
8 years, 5 months ago (2011-01-22 20:08:47 UTC) #10
pls
Sounds like there is something wrong with this patch. I will have a look at ...
8 years, 5 months ago (2011-01-22 20:17:05 UTC) #11
pls
Hi Graham, I haven't forgotten this patch but unfortunately I don't seem to find time ...
8 years, 4 months ago (2011-01-29 11:09:34 UTC) #12
Graham Percival (old account)
8 years, 4 months ago (2011-02-14 22:22:05 UTC) #13
This issue should be closed; a new patch is at:
http://codereview.appspot.com/4186049/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b