Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1093)

Issue 357840043: Give \key command a better predicate for scale type

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by dak
Modified:
4 weeks, 1 day ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Give \key command a better predicate for scale type { \key c major } should not be accepted at the parsing state, turning "major" into '(major) matching the list? predicate. So instead a number-pair-list? predicate is being used which is much less likely to be matched by erroneous input.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ly/music-functions-init.ly View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
thomasmorley651
4 weeks, 1 day ago (2018-11-15 22:04:41 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b