Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1282)

Side by Side Diff: Source/WebCore/ChangeLog

Issue 357810044: More wip
Patch Set: Created 5 years, 5 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/platform/mac-wk1/TestExpectations ('k') | Source/WebCore/dom/Document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 2018-10-01 Ali Juma <ajuma@chromium.org>
2
3 Flaky IntersectionObserver web platform tests involving style updates
4 https://bugs.webkit.org/show_bug.cgi?id=189091
5
6 Reviewed by NOBODY (OOPS!).
7
8 Update intersection observations when flushing layers from the WebProces s
9 to the UIProcess to make the timing of these updates more predictable, a nd
10 more consistent with the IntersectionObserver spec, since the spec expec ts
11 these updates to happen as part of the "Update the rendering" step in th e
12 HTML EventLoop.
13
14 Getting a similar approach to work with WK1 seems to add more complexity than it's
15 worth, since flushes don't happen for scrolls handled by platform widget s, and
16 flushes for other invalidations only happen when in compositing mode.
17
18 The only remaining timer-driven intersection observation update is for h andling
19 the initial observation on a newly added target, which needs to happen e ven if
20 there are no changes triggering a flush.
21
22 Tested by the following tests no longer being flaky:
23 imported/w3c/web-platform-tests/intersection-observer/bounding-box.h tml
24 imported/w3c/web-platform-tests/intersection-observer/display-none.h tml
25 imported/w3c/web-platform-tests/intersection-observer/containing-blo ck.html
26
27 * dom/Document.cpp:
28 (WebCore::Document::resolveStyle):
29 (WebCore::Document::updateIntersectionObservations):
30 (WebCore::Document::scheduleForcedIntersectionObservationUpdate):
31 (WebCore::Document::scheduleIntersectionObservationUpdate): Deleted.
32 * dom/Document.h:
33 * page/FrameView.cpp:
34 (WebCore::FrameView::flushCompositingStateForThisFrame):
35 (WebCore::FrameView::viewportContentsChanged):
36 * page/IntersectionObserver.cpp:
37 (WebCore::IntersectionObserver::observe):
38 * page/Page.cpp:
39 (WebCore::Page::Page):
40 (WebCore::Page::addDocumentNeedingIntersectionObservationUpdate):
41 (WebCore::Page::updateIntersectionObservations):
42 (WebCore::Page::scheduleForcedIntersectionObservationUpdate):
43 * page/Page.h:
44
45 2018-10-03 Ali Juma <ajuma@chromium.org>
46
47 [IntersectionObserver] Handle zero-area intersections
48 https://bugs.webkit.org/show_bug.cgi?id=189624
49
50 Reviewed by NOBODY (OOPS!).
51
52 Use edge-inclusive intersection when applying clips and intersecting wit h the
53 root, so that two rects that touch each other are considered intersectin g even
54 if the area of their intersection is 0.
55
56 Covered by rebased tests in imported/w3c/web-platform-tests/intersection -observer.
57
58 * dom/Document.cpp:
59 (WebCore::computeIntersectionState):
60 (WebCore::Document::updateIntersectionObservations):
61 (WebCore::computeIntersectionRects): Deleted.
62
63 2018-09-25 Ali Juma <ajuma@chromium.org>
64
65 [IntersectionObserver] Factor out rect mapping and clipping logic from c omputeRectForRepaint
66 https://bugs.webkit.org/show_bug.cgi?id=189833
67
68 Reviewed by NOBODY (OOPS!).
69
70 Factor out the rect mapping and clipping logic from computeRectForRepain t to a new
71 computeVisibleRectInContainer method that computeRectForRepaint now call s. Make
72 computeVisibleRectInContainer take a VisibleRectContext with options to use
73 edge-inclusive intersection and to apply all clips and scrolls rather th an only
74 the clips and scrolls that are currently applied by the repaint logic. T hese
75 options will be used by IntersectionObserver in a future patch.
76
77 No new tests, no change in behavior.
78
79 * platform/graphics/FloatRect.cpp:
80 (WebCore::FloatRect::edgeInclusiveIntersect):
81 * platform/graphics/FloatRect.h:
82 * platform/graphics/LayoutRect.cpp:
83 (WebCore::LayoutRect::edgeInclusiveIntersect):
84 * platform/graphics/LayoutRect.h:
85 * rendering/RenderBox.cpp:
86 (WebCore::RenderBox::applyCachedClipAndScrollPosition const):
87 (WebCore::RenderBox::computeAbsoluteVisibleRectUsingPaintOffsetCache con st):
88 (WebCore::RenderBox::computeVisibleRectInContainer const):
89 (WebCore::RenderBox::applyCachedClipAndScrollPositionForRepaint const): Deleted.
90 (WebCore::RenderBox::shouldApplyClipAndScrollPositionForRepaint const): Deleted.
91 The iOS-specific logic in this method has moved to RenderObject::shouldA pplyCompositedContainerScrollsForRepaint.
92
93 (WebCore::RenderBox::computeRectForRepaint const): Deleted.
94 * rendering/RenderBox.h:
95 (WebCore::RenderBox::computeRectForRepaint): Deleted.
96 * rendering/RenderInline.cpp:
97 (WebCore::RenderInline::clippedOverflowRectForRepaint const):
98 (WebCore::RenderInline::computeAbsoluteVisibleRectUsingPaintOffsetCache const):
99 (WebCore::RenderInline::computeVisibleRectInContainer const):
100 (WebCore::RenderInline::computeRectForRepaint const): Deleted.
101 * rendering/RenderInline.h:
102 (WebCore::RenderInline::computeRectForRepaint): Deleted.
103 * rendering/RenderObject.cpp:
104 (WebCore::RenderObject::shouldApplyCompositedContainerScrollsForRepaint) :
105 (WebCore::RenderObject::visibleRectContextForRepaint):
106 (WebCore::RenderObject::computeRectForRepaint const):
107 (WebCore::RenderObject::computeFloatRectForRepaint const):
108 (WebCore::RenderObject::computeVisibleRectInContainer const):
109 (WebCore::RenderObject::computeFloatVisibleRectInContainer const):
110 * rendering/RenderObject.h:
111 (WebCore::RenderObject::computeAbsoluteRepaintRect const):
112 (WebCore::RenderObject::VisibleRectContext::VisibleRectContext):
113 (WebCore::RenderObject::RepaintContext::RepaintContext): Deleted.
114 (WebCore::RenderObject::computeRectForRepaint): Deleted.
115 * rendering/RenderTableCell.cpp:
116 (WebCore::RenderTableCell::computeVisibleRectInContainer const):
117 (WebCore::RenderTableCell::computeRectForRepaint const): Deleted.
118 * rendering/RenderTableCell.h:
119 * rendering/RenderView.cpp:
120 (WebCore::RenderView::computeVisibleRectInContainer const):
121 (WebCore::RenderView::computeRectForRepaint const): Deleted.
122 * rendering/RenderView.h:
123 * rendering/svg/RenderSVGForeignObject.cpp:
124 (WebCore::RenderSVGForeignObject::computeFloatVisibleRectInContainer con st):
125 (WebCore::RenderSVGForeignObject::computeVisibleRectInContainer const):
126 (WebCore::RenderSVGForeignObject::computeFloatRectForRepaint const): Del eted.
127 (WebCore::RenderSVGForeignObject::computeRectForRepaint const): Deleted.
128 * rendering/svg/RenderSVGForeignObject.h:
129 * rendering/svg/RenderSVGInline.cpp:
130 (WebCore::RenderSVGInline::computeFloatVisibleRectInContainer const):
131 (WebCore::RenderSVGInline::computeFloatRectForRepaint const): Deleted.
132 * rendering/svg/RenderSVGInline.h:
133 * rendering/svg/RenderSVGModelObject.cpp:
134 (WebCore::RenderSVGModelObject::computeFloatVisibleRectInContainer const ):
135 (WebCore::RenderSVGModelObject::computeFloatRectForRepaint const): Delet ed.
136 * rendering/svg/RenderSVGModelObject.h:
137 * rendering/svg/RenderSVGRoot.cpp:
138 (WebCore::RenderSVGRoot::computeFloatVisibleRectInContainer const):
139 (WebCore::RenderSVGRoot::computeFloatRectForRepaint const): Deleted.
140 * rendering/svg/RenderSVGRoot.h:
141 * rendering/svg/RenderSVGText.cpp:
142 (WebCore::RenderSVGText::computeVisibleRectInContainer const):
143 (WebCore::RenderSVGText::computeFloatVisibleRectInContainer const):
144 (WebCore::RenderSVGText::computeRectForRepaint const): Deleted.
145 (WebCore::RenderSVGText::computeFloatRectForRepaint const): Deleted.
146 * rendering/svg/RenderSVGText.h:
147 * rendering/svg/SVGRenderSupport.cpp:
148 (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
149 (WebCore::SVGRenderSupport::computeFloatVisibleRectInContainer):
150 (WebCore::SVGRenderSupport::computeFloatRectForRepaint): Deleted.
151 * rendering/svg/SVGRenderSupport.h:
152
1 2018-10-02 Commit Queue <commit-queue@webkit.org> 153 2018-10-02 Commit Queue <commit-queue@webkit.org>
2 154
3 Unreviewed, rolling out r236719. 155 Unreviewed, rolling out r236719.
4 https://bugs.webkit.org/show_bug.cgi?id=190197 156 https://bugs.webkit.org/show_bug.cgi?id=190197
5 157
6 this revision caused 39 layout test failures that tested for 158 this revision caused 39 layout test failures that tested for
7 scrolling, a bug was also not present in the commit or change 159 scrolling, a bug was also not present in the commit or change
8 log. (Requested by Truitt on #webkit). 160 log. (Requested by Truitt on #webkit).
9 161
10 Reverted changeset: 162 Reverted changeset:
(...skipping 7507 matching lines...) Expand 10 before | Expand all | Expand 10 after
7518 Refactor filter list checking code 7670 Refactor filter list checking code
7519 https://bugs.webkit.org/show_bug.cgi?id=185087 7671 https://bugs.webkit.org/show_bug.cgi?id=185087
7520 7672
7521 Reviewed by Antonio Gomes. 7673 Reviewed by Antonio Gomes.
7522 7674
7523 No new tests, behavior unchanged. 7675 No new tests, behavior unchanged.
7524 7676
7525 * page/animation/KeyframeAnimation.h: Add missing forward-declaration Fi lterOperations. 7677 * page/animation/KeyframeAnimation.h: Add missing forward-declaration Fi lterOperations.
7526 7678
7527 == Rolled over to ChangeLog-2018-09-11 == 7679 == Rolled over to ChangeLog-2018-09-11 ==
OLDNEW
« no previous file with comments | « LayoutTests/platform/mac-wk1/TestExpectations ('k') | Source/WebCore/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b