Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 357770043: Issue 5400: Compile with -Wno-cast-function-type when possible (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 2 weeks ago by Dan Eble
Modified:
10 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5400/ This suppresses warnings that g++ 8 issues about casts that the Guile interface requires.

Patch Set 1 #

Patch Set 2 : Compile with -Wno-cast-function-type #

Total comments: 1

Patch Set 3 : Explain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M configure.ac View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10
dak
I'd use scm_func_cast<scm_t_blabla> (actual_func) in order to mimic what reinterpret_cast does, but the implementation looks ...
10 months, 2 weeks ago (2018-08-13 07:11:38 UTC) #1
Dan Eble
On 2018/08/13 07:11:38, dak wrote: > I'd use scm_func_cast<scm_t_blabla> (actual_func) I'll do that. > Any ...
10 months, 2 weeks ago (2018-08-13 12:29:46 UTC) #2
dak
On 2018/08/13 12:29:46, Dan Eble wrote: > On 2018/08/13 07:11:38, dak wrote: > > I'd ...
10 months, 2 weeks ago (2018-08-13 12:55:39 UTC) #3
Dan Eble
On 2018/08/13 12:55:39, dak wrote: > Apropos: what have you done about the warnings regarding ...
10 months, 2 weeks ago (2018-08-13 22:06:36 UTC) #4
Dan Eble
Compile with -Wno-cast-function-type
10 months, 2 weeks ago (2018-08-14 02:12:59 UTC) #5
dak
On 2018/08/14 02:12:59, Dan Eble wrote: > Compile with -Wno-cast-function-type Sorry for noticing this late ...
10 months, 2 weeks ago (2018-08-14 06:41:43 UTC) #6
dak
https://codereview.appspot.com/357770043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/357770043/diff/20001/configure.ac#newcode220 configure.ac:220: CXXFLAGS=-Wcast-function-type This is more a sort of logic nitpick ...
10 months, 1 week ago (2018-08-15 16:43:27 UTC) #7
Dan Eble
On 2018/08/15 16:43:27, dak wrote: > This is more a sort of logic nitpick than ...
10 months, 1 week ago (2018-08-15 21:51:46 UTC) #8
dak
On 2018/08/15 21:51:46, Dan Eble wrote: > On 2018/08/15 16:43:27, dak wrote: > > This ...
10 months, 1 week ago (2018-08-15 22:09:56 UTC) #9
Dan Eble
10 months, 1 week ago (2018-08-16 02:52:29 UTC) #10
Explain
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b