Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 357720044: Doc: document grob metadata in SVG output in Notation Reference (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by pwm
Modified:
1 year, 2 months ago
Reviewers:
lilypond-pkx, lists
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: document grob metadata in SVG output in Notation Reference I.e. using the 'output-attributes' grob property to add id, class, and other attributes to the SVG output for a given grob.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add menu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M Documentation/notation/input.itely View 1 1 chunk +39 lines, -1 line 0 comments Download

Messages

Total messages: 5
pwm
Please review, thanks, -Paul
1 year, 2 months ago (2018-06-21 18:39:00 UTC) #1
lists_openlilylib.org
LGTM!
1 year, 2 months ago (2018-06-21 19:17:00 UTC) #2
lilypond-pkx
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely#newcode2780 Documentation/notation/input.itely:2780: @node SVG Output I think you will need to ...
1 year, 2 months ago (2018-06-22 07:18:20 UTC) #3
pwm
Add menu
1 year, 2 months ago (2018-06-22 15:04:52 UTC) #4
pwm
1 year, 2 months ago (2018-06-22 15:11:45 UTC) #5
On 2018/06/22 07:18:20, lilypond-pkx wrote:
>
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input....
> File Documentation/notation/input.itely (right):
> 
>
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input....
> Documentation/notation/input.itely:2780: @node SVG Output
> I think you will need to add this 'node' to the @menu section after line
#2665.

Thanks James.  I took another look and since I'm adding an @unnumberedsubsubsec
underneath the '@subsection Alternative output formats' I needed to add a new
menu for that subsection and add this new node to it.  That's what I've done in
patch set 2.  
-Paul
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b