Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(935)

Issue 35660043: code review 35660043: fmt: Fix signed zero-padding for positive floats

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by felixge
Modified:
10 years, 3 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

fmt: Fix signed zero-padding for positive floats Space padding still has the same issue, I will send a separate patch for that if this one gets accepted. Fixes issue 6856.

Patch Set 1 #

Patch Set 2 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 3 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 4 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/pkg/fmt/fmt_test.go View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/fmt/format.go View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5
felixge
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2013-12-01 17:23:51 UTC) #1
felixge
The initial patch/email had the wrong test case attached by accident. This should be fixed ...
10 years, 3 months ago (2013-12-01 21:28:21 UTC) #2
r
LGTM Please sign the CLA as described at the bottom of contribute.html
10 years, 3 months ago (2013-12-11 23:19:27 UTC) #3
felixge
On 2013/12/11 23:19:27, r wrote: > LGTM Thanks. > Please sign the CLA as described ...
10 years, 3 months ago (2013-12-12 09:22:44 UTC) #4
r
10 years, 3 months ago (2013-12-12 14:40:18 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=1e3f306f9d46 ***

fmt: Fix signed zero-padding for positive floats

Space padding still has the same issue, I will send a separate patch for that
if this one gets accepted.
Fixes issue 6856.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/35660043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b