Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(804)

Issue 355810043: Make IntersectionObserver create an initial notification

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by ajuma
Modified:
5 years, 7 months ago
Reviewers:
Visibility:
Public.

Description

Make IntersectionObserver create an initial notification

Patch Set 1 #

Patch Set 2 : Actually fire notifications #

Patch Set 3 : Update test results and add ifdefs #

Patch Set 4 : Try to address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -89 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/imported/w3c/ChangeLog View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/client-rect-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/disconnect-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/display-none-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/inline-client-rect-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-targets-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-thresholds-expected.txt View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/remove-element-expected.txt View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/root-margin-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-no-root-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-root-expected.txt View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/shadow-content-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/text-target-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/timestamp-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/unclipped-root-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/intersection-observer/root-element-deleted.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/intersection-observer/root-element-moved.html View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/intersection-observer/root-element-moved-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +48 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.h View 1 2 3 4 chunks +21 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 2 3 4 chunks +68 lines, -1 line 0 comments Download
M Source/WebCore/dom/Element.cpp View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download
M Source/WebCore/page/IntersectionObserver.h View 1 2 3 2 chunks +32 lines, -9 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.cpp View 1 2 3 4 chunks +87 lines, -10 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.idl View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b