Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 355750043: Issue 5380: Fix `make doc` with non-clean build directory

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by trueroad
Modified:
4 months, 3 weeks ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5380: Fix `make doc` with non-clean build directory There was a possibility that the wrong PDF is output if the build directory is not clean. This commit makes `make doc` removes old files in the destination directories `offline-root` and `online-root`.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M scripts/build/www_post.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Dan Eble
https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py File scripts/build/www_post.py (right): https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py#newcode97 scripts/build/www_post.py:97: os.link (f, strip_file_name[t] (f)) This is not a reason ...
5 months ago (2018-07-13 22:54:48 UTC) #1
trueroad
Use variable
5 months ago (2018-07-14 03:09:32 UTC) #2
trueroad
Thank you for your reviewing. https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py File scripts/build/www_post.py (right): https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py#newcode97 scripts/build/www_post.py:97: os.link (f, strip_file_name[t] (f)) ...
5 months ago (2018-07-14 03:11:05 UTC) #3
trueroad
4 months, 3 weeks ago (2018-07-19 13:36:09 UTC) #4
I've pushed to staging.

commit 37377b14f940176dfafdc60401645191c7f7c2e1
Date:   Sat Jul 14 00:39:26 2018 +0900

Issue 5380: Fix `make doc` with non-clean build directory
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b