Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2316)

Issue 353780043: Add documentation advising against using gsutil rsync or cp over directories containing symlinks

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 2 days ago by Mike Schwartz
Modified:
3 days, 18 hours ago
Reviewers:
houglum, nstock
CC:
thobrla, gsutil-crs_google.com
Visibility:
Public.

Description

Add documentation advising against using gsutil rsync or cp over directories containing symlinks

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes per review comments #

Patch Set 3 : Rev per next review comments #

Patch Set 4 : more review commments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gslib/utils/parallelism_framework_util.py View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10
Mike Schwartz
Replacing https://codereview.appspot.com/342260043/
3 weeks, 2 days ago (2018-09-22 20:14:31 UTC) #1
nstock
https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py File gslib/commands/rsync.py (right): https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py#newcode231 gslib/commands/rsync.py:231: We recommend that customers either: Formatting nit - I'd ...
3 weeks, 1 day ago (2018-09-24 17:08:27 UTC) #2
houglum
https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py File gslib/commands/rsync.py (right): https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py#newcode212 gslib/commands/rsync.py:212: the symlinks point. In most cases this is not ...
3 weeks ago (2018-09-24 17:59:20 UTC) #3
Mike Schwartz
https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py File gslib/commands/rsync.py (right): https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py#newcode212 gslib/commands/rsync.py:212: the symlinks point. In most cases this is not ...
3 weeks ago (2018-09-24 18:21:10 UTC) #4
houglum
https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py File gslib/commands/rsync.py (right): https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py#newcode212 gslib/commands/rsync.py:212: the symlinks point. In most cases this is not ...
3 weeks ago (2018-09-24 19:41:56 UTC) #5
Mike Schwartz
https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py File gslib/commands/rsync.py (right): https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py#newcode212 gslib/commands/rsync.py:212: the symlinks point. In most cases this is not ...
3 weeks ago (2018-09-24 20:00:26 UTC) #6
houglum
On 2018/09/24 20:00:26, Mike Schwartz wrote: > https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py > File gslib/commands/rsync.py (right): > > https://codereview.appspot.com/353780043/diff/1/gslib/commands/rsync.py#newcode212 ...
3 weeks ago (2018-09-24 20:06:50 UTC) #7
nstock
LGTM
3 weeks ago (2018-09-24 22:21:25 UTC) #8
Mike Schwartz
3 days, 19 hours ago (2018-10-12 22:06:09 UTC) #9
Mike Schwartz
3 days, 18 hours ago (2018-10-12 23:00:56 UTC) #10
Please disregard. This diff belongs to a difference CL (
https://codereview.appspot.com/349790043)

On Fri, Oct 12, 2018 at 4:06 PM, <mfschwartz@google.com> wrote:

> https://codereview.appspot.com/353780043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b