Issue 353770043: Fixed Icmpv6L4Protocol messages being sent with HopLimit of DefaultTtl from Ipv6L3Protocol

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 353770043: Fixed Icmpv6L4Protocol messages being sent with HopLimit of DefaultTtl from Ipv6L3Protocol

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 7 months ago by af.oliveira

Modified:
5 years, 7 months ago

Reviewers:

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Description

Icmpv6L4Protocol::SendMessage was using Ipv4 SocketIpTtl Tag as opposed to the SocketIpv6HopLimitTag. When these ICMPv6 packets were going through the Ipv6L3Protocol class, the SocketIpv6HopLimitTag was not found, resulting in being sent with the DefaultTtl value of 64, which must not be done according to the RFC.

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/internet/model/icmpv6-l4-protocol.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download