Issue 349840043: Segfault when attempting to create an undefined grob.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 349840043: Segfault when attempting to create an undefined grob. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 2 months ago by Valentin Villenave

Modified:
5 years, 2 months ago

Reviewers:
Dan Eble

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Segfault when attempting to create an undefined grob. This commit replaces an abrupt segfault with an informative progerror message when compiling invalid code such as: \new StaffGroup \with { systemStartDelimiter = #'unknownName } { c' } Please advise whether this is appropriate.

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	lily/engraver.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Dan Eble

It's certainly an improvement. A user might appreciate seeing the input location in the error ...

5 years, 2 months ago (2019-02-10 13:36:00 UTC) #1

Valentin Villenave

5 years, 2 months ago (2019-02-14 21:59:54 UTC) #2

On 2019/02/10 13:36:00, Dan Eble wrote:
> It's certainly an improvement.
> A user might appreciate seeing the input location in the error message.

OK, pushed as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=88980c4f927bd1f911d...

Thanks!

V.

Expand All Messages | Collapse All Messages