Issue 349720043: ticket:13840 Fixing memory overflow issue in number_decimalquantity.cpp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 349720043: ticket:13840 Fixing memory overflow issue in number_decimalquantity.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 10 months ago by sffc

Modified:
5 years, 10 months ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/

Visibility:
Public.

More Reviews

Description

ticket:13840 Fixing memory overflow issue in number_decimalquantity.cpp

Patch Set 2 : Adding test in Java. #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -1 line)			Patch
M	icu4c/source/i18n/number_decimalquantity.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	icu4c/source/test/intltest/numfmtst.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	icu4c/source/test/intltest/numfmtst.cpp	View		2 chunks	+31 lines, -0 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

andy.heninger

LGTM. Optional: use uprv_realloc instead of separate malloc & free to resize. https://codereview.appspot.com/349720043/diff/1/icu4c/source/i18n/number_decimalquantity.cpp File icu4c/source/i18n/number_decimalquantity.cpp ...

5 years, 10 months ago (2018-06-19 21:49:12 UTC) #3

LGTM for the Java test.

Expand All Messages | Collapse All Messages