Add test for chunked transfer encoding apitools fix

Add test for chunked transfer encoding apitools fix

[Mike Schwartz, 2018-10-05 00:49:04]

This CL tests the apitools fix at   https://github.com/google/apitools/pull/245

See bug / fix discussion at b/117280402

[houglum, 2018-10-05 00:59:13]

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py
File gslib/tests/test_cp.py (right):

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2954: Tests that download works correctly with a gzipped
chunkd transfer-
Nit: This second paragraph shouldn't be indented to align with the first.

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2954: Tests that download works correctly with a gzipped
chunkd transfer-
s/chunkd/chunked/

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2965: input_filename = 'gslib/data/favicon.ico.gz'
This only works if your CWD is the root of the gsutil directory. E.g. if you ran
`cd $HOME; /path/to/gsutil/gsutil test <...>`, it would try to look in your home
directory for `gslib/data/favicon.ico.gz`.

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2969: # Compute the crc32c of the uncompressed bytes.
Do we want to perform this test even `UsingCrcmodExtension` returns false?

[Mike Schwartz, 2018-10-05 15:21:54]

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py
File gslib/tests/test_cp.py (right):

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2954: Tests that download works correctly with a gzipped
chunkd transfer-
On 2018/10/05 00:59:13, houglum wrote:
> Nit: This second paragraph shouldn't be indented to align with the first.

Done.

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2954: Tests that download works correctly with a gzipped
chunkd transfer-
On 2018/10/05 00:59:13, houglum wrote:
> s/chunkd/chunked/

Done.

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2965: input_filename = 'gslib/data/favicon.ico.gz'
On 2018/10/05 00:59:13, houglum wrote:
> This only works if your CWD is the root of the gsutil directory. E.g. if you
ran
> `cd $HOME; /path/to/gsutil/gsutil test <...>`, it would try to look in your
home
> directory for `gslib/data/favicon.ico.gz`.

Done.

https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcod...
gslib/tests/test_cp.py:2969: # Compute the crc32c of the uncompressed bytes.
On 2018/10/05 00:59:13, houglum wrote:
> Do we want to perform this test even `UsingCrcmodExtension` returns false?

It's a small file so performance wouldn't be a problem but it would complain
about not having a compiled module so I switched to MD5.

[houglum, 2018-10-05 22:40:46]

LGTM, just one nit.

https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py
File gslib/tests/test_cp.py (right):

https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py#ne...
gslib/tests/test_cp.py:2966: os.path.dirname(sys.modules['gslib'].__file__),
Nit: this path is already available in the gslib module, via the GSLIB_DIR
attribute.

[Mike Schwartz, 2018-10-05 23:04:58]

https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py
File gslib/tests/test_cp.py (right):

https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py#ne...
gslib/tests/test_cp.py:2966: os.path.dirname(sys.modules['gslib'].__file__),
On 2018/10/05 22:40:46, houglum wrote:
> Nit: this path is already available in the gslib module, via the GSLIB_DIR
> attribute.

Done.

[houglum, 2018-10-05 23:50:21]

LGTM