Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1224)

Issue 349010043: Add test for chunked transfer encoding apitools fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Mike Schwartz
Modified:
1 month, 2 weeks ago
Reviewers:
houglum
CC:
jterrace, gsutil-crs_google.com
Visibility:
Public.

Description

Add test for chunked transfer encoding apitools fix

Patch Set 1 #

Total comments: 8

Patch Set 2 : Response to review comments #

Total comments: 2

Patch Set 3 : Use GSLIB_DIR var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gslib/tests/test_cp.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Mike Schwartz
This CL tests the apitools fix at https://github.com/google/apitools/pull/245 See bug / fix discussion at b/117280402
2 months ago (2018-10-05 00:49:04 UTC) #1
houglum
https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py File gslib/tests/test_cp.py (right): https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcode2954 gslib/tests/test_cp.py:2954: Tests that download works correctly with a gzipped chunkd ...
2 months ago (2018-10-05 00:59:13 UTC) #2
Mike Schwartz
https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py File gslib/tests/test_cp.py (right): https://codereview.appspot.com/349010043/diff/1/gslib/tests/test_cp.py#newcode2954 gslib/tests/test_cp.py:2954: Tests that download works correctly with a gzipped chunkd ...
2 months ago (2018-10-05 15:21:54 UTC) #3
houglum
LGTM, just one nit. https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py File gslib/tests/test_cp.py (right): https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py#newcode2966 gslib/tests/test_cp.py:2966: os.path.dirname(sys.modules['gslib'].__file__), Nit: this path is ...
2 months ago (2018-10-05 22:40:46 UTC) #4
Mike Schwartz
https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py File gslib/tests/test_cp.py (right): https://codereview.appspot.com/349010043/diff/20001/gslib/tests/test_cp.py#newcode2966 gslib/tests/test_cp.py:2966: os.path.dirname(sys.modules['gslib'].__file__), On 2018/10/05 22:40:46, houglum wrote: > Nit: this ...
2 months ago (2018-10-05 23:04:58 UTC) #5
houglum
2 months ago (2018-10-05 23:50:21 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b