Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)

Issue 348990043: Issue 5415: Fix type-conversion warnings in parser and lexer

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by Dan Eble
Modified:
1 week, 3 days ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5415/ commit 75b201ce558ba18ecf510fe1c67a2f9bff14abfe (HEAD -> dev/issue-5415-warnings-lexer-parser) Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Sep 8 14:52:03 2018 -0400 Issue 5415/2: lexer: move repeated code into a skip_chars() method In passing, fix type-conversion warnings produced by g++ 8.0.1 on x86_64. commit 94b744295eb093d6b703e6aa7bba2b5c47bba2f8 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Sep 8 09:44:19 2018 -0400 Issue 5415/1: fix some parsing type-conversion warnings observed with g++ 8.0.1 on x86_64 1. Remove a condition in MYBACKUP that serves no current purpose. The compiler warned about using an enum in bool context. 2. Change the result of Keyword_table::lookup() from vsize to int. The source data is an int and the caller was converting the vsize back to int. The compiler warned about the latter.

Patch Set 1 #

Total comments: 5

Patch Set 2 : response to feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -43 lines) Patch
M lily/includable-lexer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M lily/include/includable-lexer.hh View 2 chunks +3 lines, -1 line 0 comments Download
M lily/include/input.hh View 1 chunk +3 lines, -2 lines 0 comments Download
M lily/include/keyword.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/input.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M lily/keyword.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/lexer.ll View 3 chunks +3 lines, -22 lines 0 comments Download
M lily/parser.yy View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3
dak
https://codereview.appspot.com/348990043/diff/1/lily/includable-lexer.cc File lily/includable-lexer.cc (right): https://codereview.appspot.com/348990043/diff/1/lily/includable-lexer.cc#newcode163 lily/includable-lexer.cc:163: for (size_t i = 0; i < count; ++i) ...
1 week, 3 days ago (2018-09-09 09:45:53 UTC) #1
Dan Eble
https://codereview.appspot.com/348990043/diff/1/lily/include/keyword.hh File lily/include/keyword.hh (right): https://codereview.appspot.com/348990043/diff/1/lily/include/keyword.hh#newcode40 lily/include/keyword.hh:40: int lookup (char const *s) const; On 2018/09/09 09:45:53, ...
1 week, 3 days ago (2018-09-09 17:44:12 UTC) #2
Dan Eble
1 week, 3 days ago (2018-09-09 18:33:33 UTC) #3
response to feedback
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b