Issue 348840043: [plaso] Migrated Safari cookies construct-based parser to use dtfabric #1893

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 348840043: [plaso] Migrated Safari cookies construct-based parser to use dtfabric #1893 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 11 months ago by Joachim Metz

Modified:
5 years, 10 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing

Visibility:
Public.

[plaso] Migrated Safari cookies construct-based parser to use dtfabric #1893

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -112 lines)			Patch
M	plaso/parsers/dtfabric_parser.py	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	plaso/parsers/safari_cookies.py	View	1	6 chunks	+135 lines, -109 lines	0 comments	Download
A	plaso/parsers/safari_cookies.yaml	View	1	1 chunk	+121 lines, -0 lines	0 comments	Download

Total messages: 4

onager

On 2018/06/10 08:23:28, Joachim Metz wrote: > Code updated. Reviewing on github

5 years, 10 months ago (2018-06-17 12:29:23 UTC) #3

Joachim Metz

5 years, 10 months ago (2018-06-18 17:50:45 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close dtfabric5