Issue 34830045: code review 34830045: go/build: Set GOARCH on arm64 systems.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 34830045: code review 34830045: go/build: Set GOARCH on arm64 systems. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by mwhudson

Modified:
10 years, 2 months ago

Reviewers:
iant

CC:
gofrontend-dev_googlegroups.com, iant

Visibility:
Public.

Description

go/build: Set GOARCH on arm64 systems. I am reliably informed that the architecture name and letter for the plan9/inferno compilers for 64-bit ARM systems will be "arm64" and "7" respectively, so let's get that bit in nice and early.

Patch Set 1 #

Patch Set 2 : diff -r fa6c22b293e8 https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r fa6c22b293e8 https://code.google.com/p/gofrontend/ #

Patch Set 4 : diff -r fa6c22b293e8 https://code.google.com/p/gofrontend/ #

Patch Set 5 : diff -r fa6c22b293e8 https://code.google.com/p/gofrontend/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
M	libgo/configure.ac	View	1	3 chunks	+6 lines, -0 lines	0 comments	Download
M	libgo/go/go/build/build.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	libgo/go/go/build/deps_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/go/go/build/syslist.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/go/runtime/extern.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mwhudson

Hello gofrontend-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/gofrontend/

10 years, 4 months ago (2013-11-28 21:12:15 UTC) #1

iant

10 years, 3 months ago (2014-01-06 19:23:45 UTC) #3

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=77fca9a77a8b ***

go/build: Set GOARCH on arm64 systems.

I am reliably informed that the architecture name and letter for the
plan9/inferno compilers for 64-bit ARM systems will be "arm64" and "7"
respectively, so let's get that bit in nice and early.

R=gofrontend-dev, iant
CC=gofrontend-dev
https://codereview.appspot.com/34830045

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages