Issue 347800043: [plaso] Migrated cups_ipp construct-based parser to use dtfabric #1893

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 347800043: [plaso] Migrated cups_ipp construct-based parser to use dtfabric #1893 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 11 months ago by Joachim Metz

Modified:
5 years, 10 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing

Visibility:
Public.

[plaso] Migrated cups_ipp construct-based parser to use dtfabric #1893

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+366 lines, -219 lines)			Patch
	M	plaso/parsers/cups_ipp.py	View	1 2	8 chunks	+248 lines, -219 lines	0 comments	Download
	A	plaso/parsers/cups_ipp.yaml	View	1 2	1 chunk	+118 lines, -0 lines	0 comments	Download

Total messages: 6

onager

On 2018/06/10 05:52:41, Joachim Metz wrote: > Code updated. Reviewing on github

5 years, 10 months ago (2018-06-13 14:19:18 UTC) #4

Joachim Metz

5 years, 10 months ago (2018-06-18 07:21:18 UTC) #6

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close dtfabric2