Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1652)

Issue 347730043: ticket:13634 Full merge of branch to trunk.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by sffc
Modified:
5 years, 10 months ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13634 Full merge of branch to trunk.

Patch Set 1 #

Patch Set 2 : Adding change to ICU4C. Some tests are failing. #

Patch Set 3 : Adding locale long name parsing as alternative to currency data parsing. Test cases are passing ag… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -161 lines) Patch
M icu4c/source/i18n/numparse_affixes.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + icu4c/source/i18n/numparse_affixes.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/numparse_currency.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
A + icu4c/source/i18n/numparse_currency.cpp View 1 2 2 chunks +60 lines, -24 lines 0 comments Download
M icu4c/source/i18n/numparse_impl.cpp View 1 2 5 chunks +7 lines, -4 lines 0 comments Download
M icu4c/source/i18n/numparse_types.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M icu4c/source/test/cintltst/cnumtst.c View 1 2 5 chunks +36 lines, -38 lines 0 comments Download
M icu4c/source/test/intltest/numbertest_parse.cpp View 1 2 2 chunks +41 lines, -19 lines 0 comments Download
M icu4c/source/test/intltest/numfmtst.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M icu4c/source/test/testdata/numberformattestspecification.txt View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
A + icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/AffixTokenMatcherFactory.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A + icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/CombinedCurrencyMatcher.java View 1 2 7 chunks +62 lines, -17 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java View 1 2 5 chunks +7 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ParsingUtils.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/data/numberformattestspecification.txt View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 6 chunks +34 lines, -25 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberParserTest.java View 1 2 2 chunks +38 lines, -18 lines 0 comments Download

Messages

Total messages: 3
sffc
Here is a Rietveld with the code we went over today, including the changes we ...
5 years, 11 months ago (2018-04-24 02:36:09 UTC) #1
sffc
Adding change to ICU4C. Some tests are failing.
5 years, 10 months ago (2018-05-16 00:58:12 UTC) #2
sffc
5 years, 10 months ago (2018-05-16 22:57:28 UTC) #3
Adding locale long name parsing as alternative to currency data parsing.  Test
cases are passing again.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b