Issue 347080043: add very short and Henze fermatas

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 347080043: add very short and Henze fermatas

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 1 month ago by Malte Meyn

Modified:
5 years, 1 month ago

Reviewers:
carl.d.sorensen, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

add very short and Henze fermatas These were missing for SMuFL compliance.

Patch Set 2 : Remove the new fermatas from script-chart.ly. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -84 lines)			Patch
M	Documentation/changes.tely	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	mf/feta-scripts.mf	View		2 chunks	+218 lines, -0 lines	0 comments	Download
M	ps/encodingdefs.ps	View		2 chunks	+92 lines, -83 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Malte Meyn

The SMuFL fermatas can be seen at https://w3c.github.io/smufl/gitbook/tables/holds-and-pauses.html

5 years, 1 month ago (2019-03-01 09:38:10 UTC) #1

lemzwerg

LGTM, thanks! https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf File mf/feta-scripts.mf (right): https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122 mf/feta-scripts.mf:122: .. z6{up} Indentation

5 years, 1 month ago (2019-03-04 05:05:02 UTC) #4

Malte Meyn

5 years, 1 month ago (2019-03-04 07:47:18 UTC) #5

Thanks for the review, I’ll use the correct indentation when pushing.

https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):

https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122
mf/feta-scripts.mf:122: .. z6{up}
On 2019/03/04 05:05:02, lemzwerg wrote:
> Indentation

Done.

Expand All Messages | Collapse All Messages