Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 347080043: add very short and Henze fermatas

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by Malte Meyn
Modified:
6 months, 2 weeks ago
Reviewers:
carl.d.sorensen, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add very short and Henze fermatas These were missing for SMuFL compliance.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove the new fermatas from script-chart.ly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -84 lines) Patch
M Documentation/changes.tely View 1 2 chunks +12 lines, -1 line 0 comments Download
M mf/feta-scripts.mf View 2 chunks +218 lines, -0 lines 0 comments Download
M ps/encodingdefs.ps View 2 chunks +92 lines, -83 lines 0 comments Download

Messages

Total messages: 5
Malte Meyn
The SMuFL fermatas can be seen at https://w3c.github.io/smufl/gitbook/tables/holds-and-pauses.html
6 months, 3 weeks ago (2019-03-01 09:38:10 UTC) #1
Carl
Looks excellent to me. THanks for taking care of this. Carl
6 months, 3 weeks ago (2019-03-01 20:01:15 UTC) #2
Malte Meyn
Remove the new fermatas from script-chart.ly.
6 months, 2 weeks ago (2019-03-02 10:45:23 UTC) #3
lemzwerg
LGTM, thanks! https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf File mf/feta-scripts.mf (right): https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122 mf/feta-scripts.mf:122: .. z6{up} Indentation
6 months, 2 weeks ago (2019-03-04 05:05:02 UTC) #4
Malte Meyn
6 months, 2 weeks ago (2019-03-04 07:47:18 UTC) #5
Thanks for the review, I’ll use the correct indentation when pushing.

https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):

https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122
mf/feta-scripts.mf:122: .. z6{up}
On 2019/03/04 05:05:02, lemzwerg wrote:
> Indentation

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b