Issue 346930044: Issue 5410: Fix warnings in flower

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 346930044: Issue 5410: Fix warnings in flower (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 7 months ago by Dan Eble

Modified:
5 years, 7 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fix warnings in flower coming from g++ 8.0.1 on x86_64. https://sourceforge.net/p/testlilyissues/issues/5410/ Three commits: * remove unused memrchr and memrev * remove unused Polynomial::set_mod * fix remaining int/size conversion warnings

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -79 lines)			Patch
M	flower/include/libc-extension.hh	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	flower/include/polynomial.hh	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	flower/include/std-string.hh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	flower/include/string-convert.hh	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	flower/libc-extension.cc	View	4 chunks	+2 lines, -26 lines	0 comments	Download
M	flower/polynomial.cc	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	flower/std-string.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	flower/string-convert.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	flower/warn.cc	View	1 chunk	+1 line, -1 line	0 comments	Download