Issue 346930043: V1 of making sure that IO doesn't keep document alive longer than it should

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 7 months ago by ajuma

Modified:
5 years, 7 months ago

Reviewers:

Visibility:
Public.

V1 of making sure that IO doesn't keep document alive longer than it should

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -20 lines)			Patch
A	LayoutTests/intersection-observer/no-document-leak.html	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A	LayoutTests/intersection-observer/observer-and-callback-without-js-references.html	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	LayoutTests/intersection-observer/observer-and-callback-without-js-references-expected.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/WebCore/Sources.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/WebCore.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp	View	2 chunks	+19 lines, -17 lines	0 comments	Download
M	Source/WebCore/page/IntersectionObserver.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/WebCore/page/IntersectionObserver.cpp	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	Source/WebCore/page/IntersectionObserver.idl	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/page/IntersectionObserverCallback.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/WebCore/page/IntersectionObserverCallback.idl	View	1 chunk	+2 lines, -1 line	0 comments	Download