Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 346920043: issue 5393: Another fingering vs. accidental problem

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by Be-3
Modified:
2 weeks, 6 days ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue 5393: Another fingering vs. accidental problem modified: ../input/regression/finger-chords-accidental.ly modified: ../input/regression/finger-chords-dot.ly Existing regression tests supplemented by critical collision cases. modified: ../lily/new-fingering-engraver.cc - dots of all noteheads considered to avoid collisionts with fingerings - Y-offset callback had been too late for correct X positioning: (A) Y-center stencil for FingeringColumn ---or--- (B) Setting Y-offset (considering Y-offset set by user plus self-alignment-Y and parent-alignment-Y) This is compatible to current behaviour (except for being in time) - add_string function removed (obsolete, never used)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M input/regression/finger-chords-accidental.ly View 1 chunk +7 lines, -1 line 0 comments Download
M input/regression/finger-chords-dot.ly View 1 chunk +1 line, -0 lines 0 comments Download
M lily/new-fingering-engraver.cc View 2 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 1
Be-3
2 weeks, 6 days ago (2018-08-30 17:31:32 UTC) #1
Please review.
Thanks,
Torsten
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b