Issue 34680044: code review 34680044: cmd/go: Add support for coverage in CgoFiles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 34680044: code review 34680044: cmd/go: Add support for coverage in CgoFiles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by Hierro

Modified:
10 years ago

Reviewers:
r, gobot, rsc, golang-codereviews

Visibility:
Public.

Description

cmd/go: Add support for coverage in CgoFiles Add CgoFiles to the covered files when building with cover support.

Patch Set 1 #

Patch Set 2 : diff -r 7326da92ff4d https://code.google.com/p/go #

Patch Set 3 : diff -r 7326da92ff4d https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -21 lines)			Patch
	M	src/cmd/go/build.go	View	1	2 chunks	+30 lines, -19 lines	0 comments	Download
	M	src/cmd/go/test.go	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 10

Expand All Messages | Collapse All Messages

Hierro

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2013-12-02 02:07:43 UTC) #1

rsc

This looks good but can you please add a test case to test.bash?

10 years, 3 months ago (2014-01-07 02:00:49 UTC) #6

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=8f3d507a31e0 *** cmd/go: add support for coverage in CgoFiles Add CgoFiles to ...

10 years, 1 month ago (2014-03-05 19:28:14 UTC) #8

Hierro

10 years ago (2014-03-23 16:53:43 UTC) #10

On 2014/03/05 19:29:07, rsc wrote:
> I have sent CL 71230049 with a test case.

Thanks! I was waiting until I had time to check how to properly add a test in
test.bash, but you bet me to it.

Regards,
Alberto

Expand All Messages | Collapse All Messages