Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 346070043: Remove Moment::as_scheme

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by dak
Modified:
2 months, 1 week ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove Moment::as_scheme It's a remnant of some design long abandoned.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M lily/include/moment.hh View 1 chunk +1 line, -4 lines 0 comments Download
M lily/moment.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
LGTM and I would not fault you if you chose to push this immediately after ...
2 months, 1 week ago (2018-06-13 21:11:38 UTC) #1
dak
2 months, 1 week ago (2018-06-13 21:25:44 UTC) #2
On 2018/06/13 21:11:38, Dan Eble wrote:
> LGTM and I would not fault you if you chose to push this immediately after
> receiving independent confirmation that it builds.

Shrug.  I have no dependencies on this one.  It can sit in its branch until the
shoe drops.  I just found it when using Moment as a sort of template for a new
Transform class and dug around finding what it's even being used for.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b