Issue 345900043: [l2tdevtools] Changes to dependency writers for sdist and jenkins support #331

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 345900043: [l2tdevtools] Changes to dependency writers for sdist and jenkins support #331 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
5 years, 11 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com, jberggren

Visibility:
Public.

More Reviews

Description

[l2tdevtools] Changes to dependency writers for sdist and jenkins support #331

Patch Set 1 : Changed run with timeout script to return child exit code #

Patch Set 2 : Changes for jenkins support #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -390 lines)			Patch
D	data/templates/.travis.yml	View		1 chunk	+0 lines, -47 lines	0 comments	Download
A	data/templates/.travis.yml/allow_failures	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	data/templates/.travis.yml/footer	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	data/templates/.travis.yml/header	View		1 chunk	+0 lines, -8 lines	0 comments	Download
A	data/templates/.travis.yml/jenkins	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	data/templates/run_with_timeout.sh	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	data/templates/runtests.sh	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
D	data/templates/setup.py	View		1 chunk	+0 lines, -164 lines	0 comments	Download
A	data/templates/setup.py/bdist_msi	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A +	data/templates/setup.py/bdist_rpm	View		2 chunks	+0 lines, -82 lines	0 comments	Download
A +	data/templates/setup.py/bdist_rpm_package_data	View		3 chunks	+1 line, -82 lines	0 comments	Download
A	data/templates/setup.py/header	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/import_module	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/import_sdist	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/setup_classifiers	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/setup_cmdclass	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/setup_cmdclass_sdist	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/setup_footer	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/setup_header	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	data/templates/setup.py/setup_package_data	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	l2tdevtools/dependency_writers/setup.py	View		2 chunks	+73 lines, -3 lines	0 comments	Download
M	l2tdevtools/dependency_writers/travis_yml.py	View		1 chunk	+37 lines, -3 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Joachim Metz

5 years, 11 months ago (2018-05-10 04:42:53 UTC) #7

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close deps

Expand All Messages | Collapse All Messages