Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1570)

Issue 345800043: [plaso] Changes for int exceeds XML-RPC limits #1815 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by Joachim Metz
Modified:
7 months, 2 weeks ago
Reviewers:
romaing
CC:
kiddi, log2timeline-dev_googlegroups.com, onager
Visibility:
Public.

Description

[plaso] Changes for int exceeds XML-RPC limits #1815

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes for int exceeds XML-RPC limits #1815 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M plaso/multi_processing/worker_process.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Joachim Metz
8 months, 1 week ago (2018-04-07 12:05:59 UTC) #1
onager
https://codereview.appspot.com/345800043/diff/1/plaso/multi_processing/worker_process.py File plaso/multi_processing/worker_process.py (right): https://codereview.appspot.com/345800043/diff/1/plaso/multi_processing/worker_process.py#newcode95 plaso/multi_processing/worker_process.py:95: It looks like UpdateWorkerStatus in processing_status.py also needs to ...
8 months, 1 week ago (2018-04-07 13:49:09 UTC) #2
Joachim Metz
https://codereview.appspot.com/345800043/diff/1/plaso/multi_processing/worker_process.py File plaso/multi_processing/worker_process.py (right): https://codereview.appspot.com/345800043/diff/1/plaso/multi_processing/worker_process.py#newcode95 plaso/multi_processing/worker_process.py:95: not at the moment, this value is not checked ...
8 months, 1 week ago (2018-04-07 15:43:26 UTC) #3
Joachim Metz
Code updated.
7 months, 2 weeks ago (2018-04-24 04:13:11 UTC) #4
romaing
LGTM
7 months, 2 weeks ago (2018-04-26 16:19:56 UTC) #5
Joachim Metz
7 months, 2 weeks ago (2018-04-27 03:33:54 UTC) #6
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close rpc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b