Issue 345780043: [l2tdevtools] Added initial verion of setup.py dependency writer #157

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 345780043: [l2tdevtools] Added initial verion of setup.py dependency writer #157 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
6 years ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, onager

Visibility:
Public.

More Reviews

Description

[l2tdevtools] Added initial verion of setup.py dependency writer #157

Patch Set 2 : Changes after merge #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -109 lines)			Patch
A	data/templates/setup.py	View		1 chunk	+164 lines, -0 lines	0 comments	Download
A +	l2tdevtools/dependency_writers/setup.py	View		2 chunks	+40 lines, -2 lines	0 comments	Download
D	l2tdevtools/dependency_writers/setup_cfg.py	View		1 chunk	+0 lines, -64 lines	0 comments	Download
A +	tests/dependency_writers/setup.py	View		2 chunks	+22 lines, -3 lines	0 comments	Download
D	tests/dependency_writers/setup_cfg.py	View		1 chunk	+0 lines, -35 lines	0 comments	Download
M	tools/update-dependencies.py	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jberggren

Small suggestion, otherwise LGTM https://codereview.appspot.com/345780043/diff/1/data/templates/setup.py File data/templates/setup.py (right): https://codereview.appspot.com/345780043/diff/1/data/templates/setup.py#newcode5 data/templates/setup.py:5: from __future__ import print_function I ...

6 years ago (2018-04-05 08:33:58 UTC) #2

Joachim Metz

https://codereview.appspot.com/345780043/diff/1/data/templates/setup.py File data/templates/setup.py (right): https://codereview.appspot.com/345780043/diff/1/data/templates/setup.py#newcode5 data/templates/setup.py:5: from __future__ import print_function Good point, I'll keep it ...

6 years ago (2018-04-05 20:47:38 UTC) #3

Joachim Metz

6 years ago (2018-04-05 20:53:21 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close deptools5

Expand All Messages | Collapse All Messages