Issue 345770043: [plaso] Improved engine test coverage and clean up

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 345770043: [plaso] Improved engine test coverage and clean up (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
6 years ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing, onager

Visibility:
Public.

[plaso] Improved engine test coverage and clean up

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -89 lines)			Patch
M	plaso/engine/engine.py	View	1	2 chunks	+85 lines, -84 lines	0 comments	Download
M	tests/engine/engine.py	View		3 chunks	+47 lines, -4 lines	0 comments	Download
M	tests/multi_processing/worker_process.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 4

Joachim Metz

6 years ago (2018-04-06 04:45:11 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close testsnclean2