Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1887)

Issue 344850043: [plaso] Renamed GetRetryTask to CreateRetryTask and clean up of task manager (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by Joachim Metz
Modified:
5 years, 11 months ago
Reviewers:
jberggren, onager
CC:
kiddi, log2timeline-dev_googlegroups.com, romaing
Visibility:
Public.

Description

[plaso] Renamed GetRetryTask to CreateRetryTask and clean up of task manager Depends on: * https://codereview.appspot.com/347720043/

Patch Set 1 #

Patch Set 2 : Renamed GetRetryTask to CreateRetryTask and clean up of task manager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -83 lines) Patch
M plaso/multi_processing/task_engine.py View 1 5 chunks +12 lines, -12 lines 0 comments Download
M plaso/multi_processing/task_manager.py View 1 13 chunks +81 lines, -47 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 1 4 chunks +6 lines, -2 lines 0 comments Download
M tests/multi_processing/task_manager.py View 1 4 chunks +7 lines, -22 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
5 years, 11 months ago (2018-04-21 08:45:38 UTC) #1
jberggren
On 2018/04/21 08:45:38, Joachim Metz wrote: LGTM
5 years, 11 months ago (2018-04-23 13:58:24 UTC) #2
Joachim Metz
Code updated.
5 years, 11 months ago (2018-04-23 18:33:43 UTC) #3
Joachim Metz
5 years, 11 months ago (2018-04-23 18:41:23 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close dbmerge4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b